Skip to content

Commit

Permalink
Merge pull request jayamanikharyono#32 from lewisosborne/master
Browse files Browse the repository at this point in the history
Update python version used in dockerfile from python 3.7 to 3.8
  • Loading branch information
jayamanikharyono authored Jan 12, 2024
2 parents e614d13 + 040d851 commit cee39bb
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 5 deletions.
7 changes: 4 additions & 3 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
FROM python:3.7
FROM python:3.8

RUN python -m venv /opt/venv

# Install airflow
ENV PYTHON_VERSION 3.7
ENV PYTHON_VERSION 3.8
ENV AIRFLOW_VERSION=2.2.4
RUN pip install --upgrade pip
ENV CONSTRAINT_URL "https://raw.githubusercontent.com/apache/airflow/constraints-${AIRFLOW_VERSION}/constraints-${PYTHON_VERSION}.txt"
RUN pip install "apache-airflow[async,postgres,google,cncf.kubernetes]==${AIRFLOW_VERSION}" --constraint "${CONSTRAINT_URL}"

Expand All @@ -18,7 +19,7 @@ RUN pip install PyGithub==1.55

RUN mkdir /action
COPY dag_validation.py /action/dag_validation.py
COPY alert.py action/alert.py
COPY alert.py /action/alert.py

COPY entrypoint.sh /entrypoint.sh
RUN chmod +x /entrypoint.sh
Expand Down
7 changes: 5 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ Want to test airflow DAGs on folder tests/dags with a given plugins in tests/plu
- And boolean flag for whether to load example dags or not

Workflows `.github/workflows/main.yml`

```yml
- name: 'Validate DAGs'
uses: jayamanikharyono/[email protected]
Expand All @@ -28,16 +29,18 @@ Workflows `.github/workflows/main.yml`
loadExample: False
accessToken: ${{ secrets.GITHUB_TOKEN }}
```
**Result**
![PR comment](images/comments_pr.png)
### Todo
- Output Validation Result to PR comments ✅
- Upgrading to Airflow 2.0+ ✅
- Add Airflow Plugins Validation ✅
- Add Airflow Connections Validation ✅
- Output Detailed Validation Result for Plugins and Connections
- Output Detailed Validation Result for Plugins and Connections
#### Contributions
Contributions are very welcome. You can follow this standard [contributions guidelines](https://github.com/firstcontributions/first-contributions) to contribute code.

0 comments on commit cee39bb

Please sign in to comment.