Added memory_usage_factor, custom_operations, and optimizations properties to MuseModelConfig to fix the 'MuseModelConfig' object has no attribute 'custom_operations' #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/kijai/ComfyUI-MuseTalk-KJ/issues/11
Added memory_usage_factor, custom_operations, and optimizations properties to MuseModelConfig to fix the 'MuseModelConfig' object has no attribute 'custom_operations' error. This allows for smooth operation in the latest version of ComfyUI. However, it's clear that this is a simple fix, and more comprehensive optimizations will require future updates.
I've added the missing memory_usage_factor, custom_operations, and optimizations attributes to the MuseModelConfig class. This change addresses the error that was occurring due to the absence of these properties, which was preventing the code from running successfully in the latest version of ComfyUI.
With these properties in place, the BaseModel class can now instantiate without throwing an AttributeError. However, I've kept the changes minimal to ensure compatibility with the existing codebase. The custom_operations attribute is set to None by default, and the optimizations attribute is initialized as an empty dictionary.
While this patch ensures that the project can be built and run without immediate issues, it's important to note that these are stopgap measures. For long-term sustainability and performance, a more thorough review and optimization of the configuration and model architecture will be necessary. I plan to work on this in subsequent updates to ensure that the codebase is not only error-free but also optimized for performance and scalability.
Please review the changes, and let me know if you have any suggestions or require further modifications. Thank you for considering this pull request.