feat: Add combine
parameter to Sam2Segmentation
for flexible mask outputs
#48
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update introduces a new
combine
parameter to theSam2Segmentation
node, enhancing its flexibility for segmentation tasks. Thecombine
parameter allows users to specify whether the segmentation masks should be combined into a single tensor or output as individual masks in a batch tensor format.Key Changes:
combine
Parameter:True
(default), all masks are combined into a single tensor, ensuring backward compatibility with workflows relying on combined masks.False
, the node outputs a batch tensor containing individual masks, which can be processed independently.Improved Compatibility:
MaskListToMaskBatch
expecting objects with.shape
attributes.Code Refactoring:
Testing and Validation:
combine=True
andcombine=False
scenarios.AttributeError: 'list' object has no attribute 'shape'
.This change adds flexibility for segmentation workflows while maintaining backward compatibility, making the node more versatile for varied use cases.