Work for 329 #594
Merged
Work for 329 #594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbrossie
approved these changes
Jan 17, 2025
|
|
||
| *Example 2* | ||
|
|
||
| The `logsDir` parameter defaults to `$TOMCAT_HOME/logs`. Thus, to include the `catalina.out` from the Tomcat logs directory, you can use: |
There was a problem hiding this comment.
Should this line specifying the default be moved prior (outside of Example 2) ?
There was a problem hiding this comment.
While addressing this comment, I found that I had missed documenting the scenario where the com.killbill.billing.plugin.aviate.logsPath property is specified. However, after giving it a try, I found that setting this property does not work. So I've filed #337 to track this work. I will address this comment (and add additional documentation for the com.killbill.billing.plugin.aviate.logsPath property) once #337 is addressed. Merging this PR as is for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work for https://github.com/killbill/killbill-aviate-plugin/issues/329