Base plugin 84 remove guava dependencies #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When PluginProperties.buildPluginProperties() called, there's no guarantee that the first added map entry would be the first element of the List. When using guava's ImmutableMap, it's known that guava make its implementation "sorted", so this assertion will always valid. This will not the same with JDK map. For short: - "pluginProperties1.get(0).getKey()" using Guava's ImmutableMap.of() : Will always return "foo" - "pluginProperties1.get(0).getKey()" using JDK Map.of() : No guarantee. If someone wants to see old assertions, the commit hash is: 25abb93
pierre
approved these changes
May 22, 2023
|
@pierre should I upgrade |
|
Ok, I updated the |
Maybe we should merge the upgrades that are ready in killbill-oss-parent and do a release, so that we can start upgrading dependencies in the various repos? |
pierre
reviewed
May 22, 2023
| @@ -14,6 +14,7 @@ Convenience library to help write Kill Bill plugins. | |||
| | 4.1.y | 0.22.z | | |||
| | 4.2.y | 0.22.z | | |||
| | 5.0.y | 0.24.z | | |||
| | 5.1.y | 0.24.z | | |||
|
|
|||
| We've upgraded numerous dependencies in 4.2.x (required for Java 11 support). | |||
There was a problem hiding this comment.
I would add a note like (or something along these lines):
Guava has been removed as a dependency in 5.1.x, native JDK alternatives should be used instead
Otherwise, if a user upgrades without looking at the code changes, they might get confused why the compilation errors if they implicitly rely on Guava in their plugins 😅
There was a problem hiding this comment.
We have this in NEWS commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to fix this issue: #84 :