Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: rework helm-chart #69

Merged
merged 6 commits into from
Sep 21, 2023
Merged

feat: rework helm-chart #69

merged 6 commits into from
Sep 21, 2023

Conversation

rguichard
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Aug 28, 2023 •
edited
Loading

Codecov Report

Merging #69 (4d35d09) into main (ef041fd) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main       #69   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           17        17           
  Lines          873       873           
=========================================
  Hits           873       873

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

cebidhem
cebidhem previously requested changes Aug 28, 2023
View reviewed changes
Copy link
Contributor

@cebidhem cebidhem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rguichard Just a quick suggestion on default tag.

charts/eth-validator-watcher/values.yaml Outdated Show resolved Hide resolved
@rguichard rguichard force-pushed the reset-chart branch 2 times, most recently from cb80206 to 0f620ea Compare August 28, 2023 14:54
@cebidhem cebidhem requested a review from rayanebel September 19, 2023 12:20
@cebidhem cebidhem dismissed their stale review September 19, 2023 12:20

can't be contributor + reviewer

@cebidhem cebidhem merged commit a36a9d3 into main Sep 21, 2023
5 checks passed
@nalepae nalepae deleted the reset-chart branch October 10, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cebidhem cebidhem cebidhem left review comments

@rayanebel rayanebel rayanebel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rguichard @rayanebel @cebidhem