fix(helm): use python3.11 for probes and update appVersion to 0.7.1 #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mehdi Bechiri <[email protected]>
cebidhem
requested review from
rguichard and
rayanebel
and removed request for
rguichard
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #95 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 17 17
Lines 964 964
=========================================
Hits 964 964 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Mehdi Bechiri <[email protected]>
aimxhaisse
approved these changes
Nov 30, 2023
|
Thanks a lot for fixing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v0.7.0introduced a new required version of python (3.11instead of3.9) so this updates the probes (liveness/readiness).The
appVersionwas prefixed byvbut the images produced by the repo are not prefixed byv, making default not working as is. This PR fixes it and set theappVersionto0.7.1(latest to date).