Skip to content

Commit

Permalink
remove assetId param from signAtomTx (#180)
Browse files Browse the repository at this point in the history
* remove assetId param from signAtomTx

* bump package.json
  • Loading branch information
LeTamanoir authored Jan 2, 2025
1 parent 7432b8d commit aca1062
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 4 deletions.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@kilnfi/sdk",
"version": "4.0.3",
"version": "4.0.4",
"autor": "Kiln <[email protected]> (https://kiln.fi)",
"license": "BUSL-1.1",
"description": "JavaScript sdk for Kiln API",
Expand Down
3 changes: 1 addition & 2 deletions src/fireblocks.ts
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,6 @@ export class FireblocksService {
async signAtomTx(
integration: FireblocksIntegration,
tx: components['schemas']['ATOMUnsignedTx'] | components['schemas']['ATOMStakeUnsignedTx'],
assetId: 'ATOM_COS' | 'ATOM_COS_TEST',
note?: string,
): Promise<{
signed_tx: { data: components['schemas']['ATOMSignedTx'] };
Expand All @@ -211,7 +210,7 @@ export class FireblocksService {

const fbSigner = this.getSigner(integration);
const fbNote = note ? note : 'ATOM tx from @kilnfi/sdk';
const fbTx = await fbSigner.sign(payload, assetId, fbNote);
const fbTx = await fbSigner.sign(payload, 'ATOM_COS', fbNote);
const signature = fbTx.signedMessages?.[0]?.signature.fullSig;

if (!signature) {
Expand Down
1 change: 0 additions & 1 deletion src/fireblocks_signer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ export type FireblocksAssetId =
| 'ETH_TEST5'
| 'ETH_TEST6'
| 'ETH'
| 'ATOM_COS_TEST'
| 'ATOM_COS'
| 'OSMO_TEST'
| 'OSMO'
Expand Down

0 comments on commit aca1062

Please sign in to comment.