-
-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore!: add biome instead of prettier for formatting #303
Open
curtisy1
wants to merge
21
commits into
kimlimjustin:refactor/react-redux
Choose a base branch
from
curtisy1:code-styles
base: refactor/react-redux
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@curtisy1 is attempting to deploy a commit to the Justin Maximillian Kimlim's projects Team on Vercel. A member of the Team first needs to authorize it. |
This also sets up the preliminary work needed to use biome as a linter instead of eslint by running lint:biome
This replaces unicode regex mechanism for diacritics
These should gradually be investigated and fixed without negatively impacting productivity
I fixed most of the lint rules Biome provides. Some are too tedious to fix on a small note but they can be easily added and fixed gradually (and should be!) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also sets up the preliminary work needed to use biome as a linter instead of eslint by running lint:biome
Motivation
Biome is an alternative to Prettier and ESLint, written in Rust. The main advantage of it besides speed is that it gives very useful error messages when using it as a linter, for example
This makes it easier for newcomers to understand what's happening and fix issues accordingly. It also aligns nicely with Rust's error messages
Changes
Added a biome.json files with the default ruleset and applied the prettier config on top.
After that I ran yarn format on the code base to make biome format the whole code according to prettier specification
Additional Comments
Leaving this in Draft mode for now because I plan on using Biome as a linter as well, at least for everything that is not type-checking