-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add aante-dark theme #417
add aante-dark theme #417
Conversation
I see a few visibility issues here - could you fix these for me?
Lastly, if it's really just a color inversion then we should be able to base it off the existing aante-light. Didn't do this for solarized since it has very little custom css (Just tweaking variables) but should probably do it for aante since it's much heavier in that way. Please change the variable assignments in aante-light to |
My mistake, I've only tested it on a black body.
I'll try to make all changes in next 24h. |
Could you run a |
Can you get rid of the margin/padding thing and do a build? Padding looks fine if you're dumping multiple at once or have a page only for dumps but if you're dumping at different places on a page the margin looks much cleaner, so I'd like to keep that as the default |
Yes, I will revert the commit but in contrast theme it doesn't look good. |
Well presumably you'd be using the dark theme on a dark site and it would be less jarring, but since we have no control over where it's run I'd rather keep it as margin. Can I just add a |
Yes, of course. This commit already has |
Nope, the phar file hasn't been changed - You may need to set |
Fixed in |
Merged to master - Since there are no bugs right now I'll tag it in the next minor version closer to PHP 8.3 release |
This commit adds aante-dark theme based on aante-light with inverted colors.