-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(Custom Variables) #101
Open
bshutterkion
wants to merge
11
commits into
main
Choose a base branch
from
feat(CVs)
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s and improve error handling - Added retrieval of custom variable type from API before processing values. - Modified `UnpackCvValueJsonStr` and `PackCvValueIntoJsonStr` functions to handle string, list, and map types. - Enhanced error messages for better diagnostics. - Updated schema to support `default_value_list` and `default_value_map` fields. - Improved data handling during read and update operations for `resourceCustomVariable`. This update ensures that custom variable overrides and operations are processed according to their types, enhancing robustness and type-specific handling.
…variable types - Updated `PackCvValueIntoJsonStr` and `UnpackCvValueJsonStr` to streamline handling for `string`, `list`, and `map` types. - Enhanced JSON validation for lists and maps, ensuring input adheres to expected types. - Introduced new schema fields (`value_list`, `value_map`) for handling lists and maps distinctly in `resourceCustomVariableOverride`. - Adjusted `resourceCustomVariable` to use `default_value_string`, `default_value_list`, and `default_value_map` for clarity. - Improved error messaging and handling to support comprehensive type checks and transformations.
…nctions Refactored functions to use hc.HandleError for consistent error handling and reduced code duplication. Replaced diag.Diagnostic with concise error handling and used hc.SafeSet for secure value setting in resource data.
Replaced single `value` field with distinct fields (`value_string`, `value_list`, `value_map`) for more precise type handling. Updated schema and logic for consistent handling of different data types in custom variable overrides.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.