added role editing option to user update #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mozsarmate
approved these changes
Aug 31, 2024
| if (user === null) { | ||
| throw new NotFoundException(`User with id ${id} not found`); | ||
| } else if (user.isSchResident === false && updateUserDto.roomNumber) { | ||
| throw new BadRequestException('Non-resident users cannot have a room number'); |
There was a problem hiding this comment.
ez miert fontos itt?
nem csak az admint lehet allitani ebben?
|
Hát itt tudja az admin állítani a userek adatait. Csak fura a naming, sry. Mert amúgy minden user magának is állítgathatja pl a szobaszámát. De az aktivevikstudentet pl nem
…On 31 Aug 2024, 16:41 +0200, Mozsár Máté ***@***.***>, wrote:
@mozsarmate approved this pull request.
In apps/backend/src/user/user.service.ts:
>
@Injectable()
export class UserService {
+ async updateAdmin(id: string, updateUserDto: UpdateUserAdminDto) {
+ const user = await this.prisma.user.findUnique({ where: { authSchId: id } });
+
+ if (user === null) {
+ throw new NotFoundException(`User with id ${id} not found`);
+ } else if (user.isSchResident === false && updateUserDto.roomNumber) {
+ throw new BadRequestException('Non-resident users cannot have a room number');
ez miert fontos itt?
nem csak az admint lehet allitani ebben?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hát nekem ez él a fejemben, de ha nem így kéne, akkor javítom szívesen.