Use importlib_metadata for getting the version #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jschlyter
requested changes
Sep 6, 2023
chargeamps/__init__.py
Outdated
| @@ -1,3 +1,3 @@ | |||
| import pkg_resources | |||
| from importlib_metadata import version | |||
There was a problem hiding this comment.
Is this not supposed to be importlib.metadata ?
There was a problem hiding this comment.
You actually have both options available to you. I'm not sure about the benefits/drawbacks for each in the long run. I'll update to importlib.metadata and let you decide the way forward.
hfreire
commented
Sep 8, 2023
jschlyter
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems with python 3.11 pkg_resources is deprecated: https://setuptools.pypa.io/en/latest/pkg_resources.html
When releasing python-chargeamps make sure to bump it in the hass-chargeamps repo and make a new release as this is needed for the latest version of home-assistant.