Upgrade packages and refactor a bit #500
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
voinik
commented
Nov 2, 2022
| @@ -6,8 +6,8 @@ import reducer, {State} from './reducer'; | |||
| export const makeStore = (context: Context) => { | |||
| const store = createStore(reducer, applyMiddleware(logger)); | |||
|
|
|||
| if (module.hot) { | |||
| module.hot.accept('./reducer', () => { | |||
| if ((module as any).hot) { | |||
There was a problem hiding this comment.
I'm not familliar with module.hot; it's showing type errors because that property doesn't exist in there. Is this still used?
There was a problem hiding this comment.
Yes, this is the way to hot-swap reducer on client side. This is Webpack's thing.
|
This PR should be rebased and merged once #502 is in. |
|
@voinik pls consider rebasing this PR on top of recent fixes. |
|
@kirill-konshin On it |
|
@kirill-konshin I've closed this one in favor of another PR: #519 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.