Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove the xcodeproj from the library #411

Merged
merged 1 commit into from
Apr 14, 2024

Conversation

kirillzyusko
Copy link
Owner

@kirillzyusko kirillzyusko commented Apr 14, 2024

📜 Description

Removed *.xcodeproj and all associated files.

💡 Motivation and Context

It seems like this file is not needed anymore as all linking is done via cocoapods. So in this PR I'm removing it because:

  • it should reduce npm package on ~19kb;
  • we will not need to synchronize it with fs anymore;
  • it's not used file.

Similar changes were made in callstack/react-native-builder-bob#470

📢 Changelog

iOS

  • removed xcodeproj associated files;

🤔 How Has This Been Tested?

Tested on CI.

📝 Checklist

  • CI successfully passed
  • I added new mocks and corresponding unit-tests if library API was changed

@kirillzyusko kirillzyusko added 🍎 iOS iOS specific refactor You changed the code but it didn't affect functionality labels Apr 14, 2024
@kirillzyusko kirillzyusko self-assigned this Apr 14, 2024
Copy link
Contributor

📊 Package size report

Current size Target Size Difference
bytes bytes 0 bytes 📉

@kirillzyusko kirillzyusko marked this pull request as ready for review April 14, 2024 17:56
@kirillzyusko kirillzyusko merged commit 7678eec into main Apr 14, 2024
11 checks passed
@kirillzyusko kirillzyusko deleted the chore/remove-xcodeproj branch April 14, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍎 iOS iOS specific refactor You changed the code but it didn't affect functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant