fix: allow to pass additional params to .dismiss()
unintentionally
#685
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Allow to pass additional params to
KeyboardController.dismiss()
method unintentionally.💡 Motivation and Context
When we pass params unintentionally like
onPress={KeyboardController.dismiss}
then we will try to serialize big JS object to the native side, which eventually crash the application.To avoid this I decided to wrap
dismiss
in additional function and always send empty params to a native function.Closes #684
📢 Changelog
JS
addListener
/removeListener
methods fromKeyboardController
;dismiss
;KeyboardToolbar
;🤔 How Has This Been Tested?
Tested on CI.
📝 Checklist