Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Inspector CLI Specify source and Target Timescale (pytorch#3761)
Summary: Pull Request resolved: pytorch#3761 et pal defines a function which expects "ticks" to be returned as et_timestamp_t. https://www.internalfb.com/code/fbsource/[f8d32ccd3afec7d761b6e04f1809210892973b20]/fbcode/executorch/runtime/platform/platform.h?lines=66 Inspector CLI treats these ticks as "nanoseconds" by default https://www.internalfb.com/code/fbsource/[f8d32ccd3afec7d761b6e04f1809210892973b20]/fbcode/executorch/sdk/inspector/_inspector.py?lines=610 I understand ticks and nanoseconds as different things unless operating processor at 1GHz, but don't necessarily need to change the default in case it breaks some existing workflows. Specifying source/target time scale to the CLI tool would be useful flexibility, though, since I would ultimately like our PAL to return ticks which seems to be original intent. Reviewed By: abhiag-git, tarun292 Differential Revision: D57888750 fbshipit-source-id: d0007abcf1adb5f4ce5acc39a59b0c98f4925ed7
- Loading branch information