Use c++17 for OSS gtest (pytorch#3654)

Summary: Some test code uses c++17 feature (inline static member) Pull Request resolved: pytorch#3654 Test Plan: CI. `sh test/run_oss_cpp_tests.sh` Reviewed By: shoumikhin Differential Revision: D57477500 Pulled By: kirklandsign fbshipit-source-id: b0fef3340240dcd775910cab673f6a50c9ee7088
kirklandsign · May 17, 2024 · ae311b4 · ae311b4
1 parent 4008600
commit ae311b4
Show file tree

Hide file tree

Showing 6 changed files with 12 additions and 12 deletions.
diff --git a/extension/data_loader/test/CMakeLists.txt b/extension/data_loader/test/CMakeLists.txt
@@ -16,8 +16,8 @@
 cmake_minimum_required(VERSION 3.19)
 project(extension_data_loader_test)
 
-# Use C++14 for test.
-set(CMAKE_CXX_STANDARD 14)
+# Use C++17 for test.
+set(CMAKE_CXX_STANDARD 17)
 
 set(EXECUTORCH_ROOT ${CMAKE_CURRENT_SOURCE_DIR}/../../..)
 

diff --git a/runtime/core/exec_aten/testing_util/test/CMakeLists.txt b/runtime/core/exec_aten/testing_util/test/CMakeLists.txt
@@ -16,8 +16,8 @@
 cmake_minimum_required(VERSION 3.19)
 project(runtime_core_exec_aten_testing_util_test)
 
-# Use C++14 for test.
-set(CMAKE_CXX_STANDARD 14)
+# Use C++17 for test.
+set(CMAKE_CXX_STANDARD 17)
 
 set(EXECUTORCH_ROOT ${CMAKE_CURRENT_SOURCE_DIR}/../../../../..)
 

diff --git a/runtime/core/exec_aten/util/test/CMakeLists.txt b/runtime/core/exec_aten/util/test/CMakeLists.txt
@@ -16,8 +16,8 @@
 cmake_minimum_required(VERSION 3.19)
 project(runtime_core_exec_aten_util_test)
 
-# Use C++14 for test.
-set(CMAKE_CXX_STANDARD 14)
+# Use C++17 for test.
+set(CMAKE_CXX_STANDARD 17)
 
 set(EXECUTORCH_ROOT ${CMAKE_CURRENT_SOURCE_DIR}/../../../../..)
 

diff --git a/runtime/core/portable_type/test/CMakeLists.txt b/runtime/core/portable_type/test/CMakeLists.txt
@@ -16,8 +16,8 @@
 cmake_minimum_required(VERSION 3.19)
 project(runtime_core_portable_type_test)
 
-# Use C++14 for test.
-set(CMAKE_CXX_STANDARD 14)
+# Use C++17 for test.
+set(CMAKE_CXX_STANDARD 17)
 
 set(EXECUTORCH_ROOT ${CMAKE_CURRENT_SOURCE_DIR}/../../../..)
 

diff --git a/runtime/core/test/CMakeLists.txt b/runtime/core/test/CMakeLists.txt
@@ -16,8 +16,8 @@
 cmake_minimum_required(VERSION 3.19)
 project(runtime_core_test)
 
-# Use C++14 for test.
-set(CMAKE_CXX_STANDARD 14)
+# Use C++17 for test.
+set(CMAKE_CXX_STANDARD 17)
 
 set(EXECUTORCH_ROOT ${CMAKE_CURRENT_SOURCE_DIR}/../../..)
 

diff --git a/test/utils/OSSTest.cmake.in b/test/utils/OSSTest.cmake.in
@@ -16,8 +16,8 @@
 cmake_minimum_required(VERSION 3.19)
 project({project_name})
 
-# Use C++14 for test.
-set(CMAKE_CXX_STANDARD 14)
+# Use C++17 for test.
+set(CMAKE_CXX_STANDARD 17)
 
 set(EXECUTORCH_ROOT ${{CMAKE_CURRENT_SOURCE_DIR}}/{path_to_root})