Skip to content

Commit

Permalink
XNNPACK workflow don't stop on one run error (pytorch#1077)
Browse files Browse the repository at this point in the history
Summary:
Instead, need to wait for all options (quantization/delegation) and report error in the end.

See https://github.com/pytorch/executorch/actions/runs/6631014744/job/18013650086?pr=1077, now we run all models, and see useful info like `Portable q8 ok, Delegation fp32 error, Delegation q8 error`

Pull Request resolved: pytorch#1077

Reviewed By: huydhn

Differential Revision: D50610446

Pulled By: kirklandsign

fbshipit-source-id: 1985c519026b8a28ad5512f993e65b88254694fb
  • Loading branch information
kirklandsign authored and facebook-github-bot committed Oct 24, 2023
1 parent 427641c commit d7626f2
Showing 1 changed file with 9 additions and 3 deletions.
12 changes: 9 additions & 3 deletions .ci/scripts/test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -151,21 +151,27 @@ if [[ "${BACKEND}" == "portable" ]]; then
echo "Testing ${MODEL_NAME} with portable kernels..."
test_model
else
set +e
if [[ "${BACKEND}" == *"quantization"* ]]; then
echo "::group::Testing ${MODEL_NAME} with XNNPACK quantization only..."
test_model_with_xnnpack true false
test_model_with_xnnpack true false || Q_ERROR="error"
echo "::endgroup::"
fi
if [[ "${BACKEND}" == *"delegation"* ]]; then
echo "::group::Testing ${MODEL_NAME} with XNNPACK delegation only..."
test_model_with_xnnpack false true
test_model_with_xnnpack false true || D_ERROR="error"
echo "::endgroup::"
fi
if [[ "${BACKEND}" == *"quantization"* ]] && [[ "${BACKEND}" == *"delegation"* ]]; then
echo "::group::Testing ${MODEL_NAME} with XNNPACK quantization and delegation..."
test_model_with_xnnpack true true
test_model_with_xnnpack true true || Q_D_ERROR="error"
echo "::endgroup::"
fi
set -e
if [[ -n "${Q_ERROR:-}" ]] || [[ -n "${D_ERROR:-}" ]] || [[ -n "${Q_D_ERROR:-}" ]]; then
echo "Portable q8 ${Q_ERROR:-ok}," "Delegation fp32 ${D_ERROR:-ok}," "Delegation q8 ${Q_D_ERROR:-ok}"
exit 1
fi
fi

# Test demo backend delegation
Expand Down

0 comments on commit d7626f2

Please sign in to comment.