Skip to content

Commit

Permalink
Don't trigger app-build on xnnpack changes (pytorch#1089)
Browse files Browse the repository at this point in the history
Summary:
Changes in XNNPACK directory should have its own test and we shouldn't trigger app-build on PR for it. On push it's ok to run.

Also we don't need matrix here.  Just use cmake build.

Pull Request resolved: pytorch#1089

Reviewed By: huydhn

Differential Revision: D50621394

Pulled By: kirklandsign

fbshipit-source-id: 605c25fdb22c94340aed2697f05490491257a5cd
  • Loading branch information
kirklandsign authored and facebook-github-bot committed Oct 25, 2023
1 parent dab0d71 commit f1aca09
Showing 1 changed file with 1 addition and 9 deletions.
10 changes: 1 addition & 9 deletions .github/workflows/app-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,9 @@ on:
- .github/workflows/app-build.yml
- install_requirements.sh
- backends/apple/**
- backends/xnnpack/**
- build/build_apple_frameworks.sh
- build/test_ios_ci.sh
- examples/demo-apps/**
- examples/portable/**
- examples/xnnpack/**
workflow_dispatch:

concurrency:
Expand All @@ -26,11 +23,6 @@ jobs:
test-demo-ios:
name: test-demo-ios
uses: pytorch/test-infra/.github/workflows/macos_job.yml@main
strategy:
matrix:
include:
- build-tool: cmake
fail-fast: false
with:
runner: macos-latest-xlarge
submodules: 'true'
Expand All @@ -39,7 +31,7 @@ jobs:
script: |
WORKSPACE=$(pwd)
pushd "${WORKSPACE}/pytorch/executorch"
BUILD_TOOL=${{ matrix.build-tool }}
BUILD_TOOL=cmake
# Setup MacOS dependencies as there is no Docker support on MacOS atm
PYTHON_EXECUTABLE=python bash .ci/scripts/setup-macos.sh "${BUILD_TOOL}"
# Build and test iOS Demo App
Expand Down

0 comments on commit f1aca09

Please sign in to comment.