Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] main from pytorch:main #11

Merged
merged 3 commits into from
Feb 24, 2024
Merged

[pull] main from pytorch:main #11

merged 3 commits into from
Feb 24, 2024

Conversation

pull[bot]
Copy link

@pull pull bot commented Feb 24, 2024

See Commits and Changes for more details.


Created by pull[bot]

Can you help keep this open source service alive? 💖 Please sponsor : )

SS-JIA and others added 3 commits February 23, 2024 13:32
Summary:
Pull Request resolved: #2061

## Context

This changeset introduces `VkGraphBuilder` to handle parsing an `ExportedProgram` and parsing it to construct a `VkGraph` for serialization. Most of the graph parsing functionality previously implemented in `vulkan_preprocess` is now in `VkGraphBuilder`.

The main motivation of this refactor is to simplify `vulkan_preprocess`.
ghstack-source-id: 216267433
exported-using-ghexport

Reviewed By: manuelcandales

Differential Revision: D54128091

fbshipit-source-id: f0670e76719f9bff1212c1286bd127ef4e37b94d
Summary:
Pull Request resolved: #2062

## Context

Introduce `VulkanPartitioner`. I based the implementation of `VulkanPartitioner` on `ArmPartitioner`.
ghstack-source-id: 216267434
exported-using-ghexport

Reviewed By: manuelcandales

Differential Revision: D54128090

fbshipit-source-id: b75a415e122b5791888daeae132123e97fa9a7d1
Summary:
Building from source on Google Colab reveals this issue that:

```
from executorch.extension.pybindings import portable_lib
```

Result in undefined symbols in libtorch.so. This doesn't repro in GH CI jobs probably because of cmake/compiler version difference.

Linking `libtorch.so` directly into the pybind library `portable_lib` fixes this issue.

Reviewed By: dbort

Differential Revision: D54128075

fbshipit-source-id: 18b01a0af925c00fc690c9fbcdc4ffcd13adc5d1
@pull pull bot added the ⤵️ pull label Feb 24, 2024
@pull pull bot merged commit 68ca918 into kirklandsign:main Feb 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants