Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add some strict types #142

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore: add some strict types #142

wants to merge 1 commit into from

Conversation

GeoSot
Copy link
Contributor

@GeoSot GeoSot commented Jul 6, 2023 •
edited
Loading

Just another one quality scoped PR. Adding some typed properties and return types, plus two deletions that are pointed below

@luisdalmolin is up to your decision, again

GeoSot
GeoSot commented Jul 7, 2023
View reviewed changes
src/PowerJoinClause.php Outdated Show resolved Hide resolved
luisdalmolin
luisdalmolin reviewed Jul 7, 2023
View reviewed changes
Copy link
Member

@luisdalmolin luisdalmolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it, big types fan here. I just left one comment which I think needs to be addresses, and a question.

@GeoSot GeoSot marked this pull request as ready for review July 9, 2023 19:36
@GeoSot GeoSot force-pushed the chore/add-strict-types branch from 6439d0d to d9db74f Compare September 17, 2023 23:07
@luisdalmolin
Copy link
Member

@GeoSot Sorry for the long time to merge this, but if you want to fix the merge conflicts, we can merge this.

@GeoSot GeoSot force-pushed the chore/add-strict-types branch from d9db74f to ee5f6e0 Compare October 22, 2023 19:23
@GeoSot
Copy link
Contributor Author

GeoSot commented Oct 22, 2023

It's fine @luisdalmolin.

Later you may take a look on \Kirschbaum\PowerJoins\Mixins\RelationshipsExtraMethods::getFarParent . It seems unused

@GeoSot GeoSot force-pushed the chore/add-strict-types branch from ee5f6e0 to deed185 Compare November 2, 2023 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luisdalmolin luisdalmolin luisdalmolin left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GeoSot @luisdalmolin