Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove vendor prefix when storing packages #21

Merged
merged 1 commit into from
Feb 6, 2018

Conversation

davcamer
Copy link
Contributor

@davcamer davcamer commented Feb 6, 2018

This standardizes vendored packages so that they can be found using
the string from another package's .Imports list.

This addresses the issues I described in #10.

I believe vendor/ is a safe token to split on, based on this passage in the documentation:

Code below a directory named "vendor" is importable only by code in the directory tree rooted
at the parent of "vendor", and only using an import path that omits the prefix up to and including
the vendor element.

@kisielk
Copy link
Owner

kisielk commented Feb 6, 2018

Is something wrong with the GitHub diff, or with the commit? It looks like lines were only added but the old ones were not deleted.

This standardizes vendored packages so that they can be found using
the string from another package's .Imports list.
@davcamer
Copy link
Contributor Author

davcamer commented Feb 6, 2018

That was a problem with the commit. Sorry about that.

@kisielk kisielk merged commit 0622891 into kisielk:master Feb 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants