Rule id and output id should be string by default and not numbers (#20)

kislayverma · Oct 9, 2016 · 3c7e09e · 3c7e09e
1 parent 4a3c7cd
commit 3c7e09e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/...e-core/src/main/java/com/github/kislayverma/rulette/core/metadata/RuleSystemMetaData.java b/...e-core/src/main/java/com/github/kislayverma/rulette/core/metadata/RuleSystemMetaData.java
@@ -35,9 +35,9 @@ public RuleSystemMetaData(
      */
     public void applyCustomConfiguration(RuleInputConfigurator configuration) throws Exception {
         RuleInputValueFactory.getInstance().registerRuleInputBuilder(
-            this.uniqueIdColumnName, BUILDER_REGISTRY.getDefaultBuilder(DefaultDataType.NUMBER.name()));
+            this.uniqueIdColumnName, BUILDER_REGISTRY.getDefaultBuilder(DefaultDataType.STRING.name()));
         RuleInputValueFactory.getInstance().registerRuleInputBuilder(
-            this.uniqueOutputColumnName, BUILDER_REGISTRY.getDefaultBuilder(DefaultDataType.NUMBER.name()));
+            this.uniqueOutputColumnName, BUILDER_REGISTRY.getDefaultBuilder(DefaultDataType.STRING.name()));
 
         if (configuration == null) {
             for (RuleInputMetaData rimd : inputColumnList) {

diff --git a/rulette-core/src/main/java/com/github/kislayverma/rulette/core/rule/Rule.java b/rulette-core/src/main/java/com/github/kislayverma/rulette/core/rule/Rule.java
@@ -56,7 +56,7 @@ public Rule(RuleSystemMetaData ruleSystemMetaData, Map<String, String> inputMap)
             ruleSystemMetaData.getUniqueIdColumnName(),
             UNIQUE_ID_INPUT_ID,
             RuleInputType.VALUE,
-            DefaultDataType.NUMBER.name(),
+            DefaultDataType.STRING.name(),
             (ruleId == null) ? "" : ruleId));
 
         // Construct rule input object representing ouput column
@@ -66,7 +66,7 @@ public Rule(RuleSystemMetaData ruleSystemMetaData, Map<String, String> inputMap)
             ruleSystemMetaData.getUniqueOutputColumnName(),
             UNIQUE_OUTPUT_ID_INPUT_ID,
             RuleInputType.VALUE,
-            DefaultDataType.NUMBER.name(),
+            DefaultDataType.STRING.name(),
             (ruleOutputId == null) ? "" : ruleOutputId));
     }