Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: cache restore key #168

Closed
wants to merge 2 commits into from
Closed

test: cache restore key #168

wants to merge 2 commits into from

Conversation

dmzrio
Copy link
Contributor

@dmzrio dmzrio commented Oct 29, 2024

What does this PR do?

Testing cache path

Why are we doing this? Any context or related work?

You may put your link or another here

Where should a reviewer start?

optional -- if your changes affected so much files, it is encouraged to give helper for reviewer

Screenshots

optional -- You may put the database, sequence or any diagram needed

Manual testing steps?

Steps to do tests. including all possible that can hape

Config changes

optional -- If there's config changes, put it here

Deployment instructions

optional -- Better to put it if there's some 'special case' for deployment

@dmzrio dmzrio requested a review from adeherysh as a code owner October 29, 2024 03:28
@dmzrio dmzrio requested review from adeherysh and removed request for adeherysh October 29, 2024 03:28
@@ -34,9 +34,9 @@ runs:
uses: actions/cache@v4
with:
path: ~/.pnpm-store
key: ${{ runner.os }}-pnpm-${{ hashFiles('**/pnpm-lock.yaml') }}
key: ${{ runner.os }}-nextjs-${{ hashFiles('**/pnpm-lock.yaml') }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw ini cachenya pnpm kenapa di set as cache next js ya dim, kayaknya beda lg deh kalo cachenya nextjs

@dmzrio dmzrio closed this Oct 30, 2024
@dmzrio dmzrio deleted the fix/pnpm-cache-wrong branch October 30, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants