WIP: softly connect to cloudwego-contrib/cwgo-pkg #36
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: smx-Morgan The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3 similar comments
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: smx-Morgan The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: smx-Morgan The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: smx-Morgan The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| gopkg.in/natefinch/lumberjack.v2 v2.0.0 // indirect | ||
| gopkg.in/yaml.v3 v3.0.1 // indirect | ||
| ) | ||
|
|
||
| replace github.com/apache/thrift => github.com/apache/thrift v0.13.0 | ||
|
|
||
| replace github.com/cloudwego-contrib/cwgo-pkg/registry/nacos => github.com/smx-Morgan/cwgo-pkg/registry/nacos v0.0.0-20241016000926-d56ef7e0f578 |
There was a problem hiding this comment.
registry/nacos 这部分代码看起来还没合并到 cwgo-pkg 仓库上，等 cwgo-pkg 先合并吧。再问下这个 PR 的上下文是啥呀，为什么要挪过去~
There was a problem hiding this comment.
还没有合并，这个pr是看看壳化到cwgo-pkg仓库的可行性，合并之后会重新修改这个pr的代码。挪过去的原因是 希望Hertz 与 Kitex 相同类型的组件能够同步扩展，不需要提多次pr。
whalecold
changed the title
bytedance-oss-robot
bot
added
the
do-not-merge/work-in-progress
软连接到cloudwego-contrib/cwgo-pkg