Skip to content

fix: use the correct envoy field to set the limit policy #156

fix: use the correct envoy field to set the limit policy

fix: use the correct envoy field to set the limit policy #156

Triggered via pull request September 2, 2024 07:08
Status Failure
Total duration 2m 27s
Artifacts

pr-check.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

16 errors and 8 warnings
compliant
Process completed with exit code 2.
staticcheck
inlineRouteConfig.TokensPerFill undefined (type *RouteConfigResource has no field or method TokensPerFill)","code":{"value":"compile","url":"https://staticcheck.io/docs/checks#compile"},"location":{"path":"","range":{"start":{"line":0,"column":0},"end":{"line":0,"column":0}}},"related_locations":[],"severity":"ERROR"}
staticcheck
lis1.NetworkFilters[0].InlineRouteConfig.TokensPerFill undefined (type *RouteConfigResource has no field or method TokensPerFill)","code":{"value":"compile","url":"https://staticcheck.io/docs/checks#compile"},"location":{"path":"","range":{"start":{"line":0,"column":0},"end":{"line":0,"column":0}}},"related_locations":[],"severity":"ERROR"}
staticcheck
[staticcheck] reported by reviewdog 🐶 # github.com/kitex-contrib/xds/core/xdsresource core/xdsresource/lds.go:227:4: unknown field 'TokensPerFill' in struct literal of type RouteConfigResource core/xdsresource/lds.go:239:21: inlineRouteConfig.TokensPerFill undefined (type *RouteConfigResource has no field or method TokensPerFill) Raw Output: {"source":{"name":"staticcheck","url":"https://staticcheck.io"},"message":"# github.com/kitex-contrib/xds/core/xdsresource\ncore/xdsresource/lds.go:227:4: unknown field 'TokensPerFill' in struct literal of type RouteConfigResource\ncore/xdsresource/lds.go:239:21: inlineRouteConfig.TokensPerFill undefined (type *RouteConfigResource has no field or method TokensPerFill)","code":{"value":"compile","url":"https://staticcheck.io/docs/checks#compile"},"location":{"path":"","range":{"start":{"line":0,"column":0},"end":{"line":0,"column":0}}},"related_locations":[],"severity":"ERROR"}
staticcheck
[staticcheck] reported by reviewdog 🐶 # github.com/kitex-contrib/xds/core/xdsresource [github.com/kitex-contrib/xds/core/xdsresource.test] core/xdsresource/lds.go:227:4: unknown field 'TokensPerFill' in struct literal of type RouteConfigResource core/xdsresource/lds.go:239:21: inlineRouteConfig.TokensPerFill undefined (type *RouteConfigResource has no field or method TokensPerFill) core/xdsresource/lds_test.go:86:72: lis1.NetworkFilters[0].InlineRouteConfig.TokensPerFill undefined (type *RouteConfigResource has no field or method TokensPerFill) Raw Output: {"source":{"name":"staticcheck","url":"https://staticcheck.io"},"message":"# github.com/kitex-contrib/xds/core/xdsresource [github.com/kitex-contrib/xds/core/xdsresource.test]\ncore/xdsresource/lds.go:227:4: unknown field 'TokensPerFill' in struct literal of type RouteConfigResource\ncore/xdsresource/lds.go:239:21: inlineRouteConfig.TokensPerFill undefined (type *RouteConfigResource has no field or method TokensPerFill)\ncore/xdsresource/lds_test.go:86:72: lis1.NetworkFilters[0].InlineRouteConfig.TokensPerFill undefined (type *RouteConfigResource has no field or method TokensPerFill)","code":{"value":"compile","url":"https://staticcheck.io/docs/checks#compile"},"location":{"path":"","range":{"start":{"line":0,"column":0},"end":{"line":0,"column":0}}},"related_locations":[],"severity":"ERROR"}
staticcheck
Process completed with exit code 1.
lint: core/manager/mock/response.go#L23
could not import github.com/kitex-contrib/xds/core/xdsresource (-: # github.com/kitex-contrib/xds/core/xdsresource
lint: core/xdsresource/lds.go#L227
unknown field 'TokensPerFill' in struct literal of type RouteConfigResource
lint: core/xdsresource/lds.go#L239
inlineRouteConfig.TokensPerFill undefined (type *RouteConfigResource has no field or method TokensPerFill)) (typecheck)
lint: core/manager/client.go#L31
could not import github.com/kitex-contrib/xds/core/xdsresource (-: # github.com/kitex-contrib/xds/core/xdsresource
lint: core/xdsresource/lds.go#L227
unknown field 'TokensPerFill' in struct literal of type RouteConfigResource
lint: core/xdsresource/lds.go#L239
inlineRouteConfig.TokensPerFill undefined (type *RouteConfigResource has no field or method TokensPerFill)) (typecheck)
lint: core/manager/manager_test.go#L313
declared and not used: listernTest (typecheck)
lint: core/manager/manager_test.go#L332
declared and not used: clusterTest (typecheck)
lint: core/xdsresource/lds.go#L227
unknown field 'TokensPerFill' in struct literal of type RouteConfigResource
lint: core/xdsresource/lds.go#L239
inlineRouteConfig.TokensPerFill undefined (type *RouteConfigResource has no field or method TokensPerFill)
compliant: xdssuite/circuitbreak_test.go#L28
"Conifg" should be "Config".
compliant: xdssuite/circuitbreak_test.go#L51
"Conifg" should be "Config".
compliant: xdssuite/circuitbreak_test.go#L67
"Conifg" should be "Config".
compliant: xdssuite/circuitbreak_test.go#L84
"Conifg" should be "Config".
compliant: xdssuite/circuitbreak_test.go#L101
"Conifg" should be "Config".
compliant
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
staticcheck
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v3, actions/setup-go@v3, actions/cache@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
lint
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-go@v3, golangci/golangci-lint-action@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.