feat(fqdn): support using short name access service #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whalecold
force-pushed
the
feat/fqdn
branch
3 times, most recently
from
9f1dd55 to
200c1be
Compare
ppzqh
reviewed
Dec 28, 2023
CoderPoet
reviewed
Jan 3, 2024
CoderPoet
reviewed
Jan 6, 2024
ppzqh
approved these changes
Jan 8, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CoderPoet, ppzqh, whalecold The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
feat
What this PR does / why we need it (en: English/zh: Chinese):
en:
zh: 支持在 k8s service 的场景下使用 short name 访问服务，reviews == reviews.ns.svc.domain, 同时支持使用 reviews.ns 和 reviews.ns.svc 的 host 请求。
Which issue(s) this PR fixes: