Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump up kitex version & update CI #35

Closed
wants to merge 1 commit into from

Conversation

whalecold
Copy link
Member

What type of PR is this?

chore

What this PR does / why we need it (en: English/zh: Chinese):

en: chore: bump up kitex version & update CI
zh:

Which issue(s) this PR fixes:

@bytedance-oss-robot bytedance-oss-robot bot requested a review from ppzqh November 25, 2024 12:30
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: whalecold
To complete the pull request process, please assign ppzqh after the PR has been reviewed.
You can assign the PR to them by writing /assign @ppzqh in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@@ -1,11 +1,11 @@
module github.com/kitex-contrib/xds

go 1.18
go 1.21
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里应该不强制 1.21 吧,保留 1.18 即可

@whalecold whalecold deleted the chore/update-mod branch November 29, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants