Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TSL/ATS calulation does not work properly #4461

Open
stefanCCS opened this issue Jun 8, 2021 · 8 comments
Open

TSL/ATS calulation does not work properly #4461

stefanCCS opened this issue Jun 8, 2021 · 8 comments
Labels
bug ruleset ruleset functions and configuration

Comments

@stefanCCS
Copy link
Collaborator

According to 'expectation' and source code here
https://github.com/kitodo/kitodo-production/blob/master/Kitodo/src/main/java/org/kitodo/production/process/TitleGenerator.java#L103
I would expect, that TSL/ATS is build as combination of Author and Title.
My document (PPN 1022427806) has both, as you can see here
Haupttitel:
grafik
Verfasser:
grafik

==> But, TSL/ATS is created out of Title only (after pressing "Zahnrad":
grafik

==> Please check, if there is something wrong (in my assumptions or in source code)

@matthias-ronge
Copy link
Collaborator

Maybe related: #3600

@Kathrin-Huber
Copy link
Contributor

@stefanCCS can this be closed?

@henning-gerhardt
Copy link
Collaborator

This could be related to #5207 and #5208 - it's sound familiar for me.

@andre-hohmann
Copy link
Collaborator

@henning-gerhardt :

I think, here is the problem, that not the "old" author fields (without metadata groups) can be used for the generation of ATS (author title schlüssel).
Due to the implementation of the metadata groups for personal and cooperation, the new fields must be assessed to create the ATS correctly according to the former times. That could be difficult, because the fields can be defined very flexible.

It could discussed, if a division in TSL and ATS is still necessary, or if the creation of TSL without information of the author is sufficient.

@henning-gerhardt
Copy link
Collaborator

@andre-hohmann : In 2.x the following behavoiur is implemented: if there is no author given then the tls/ats is only build by title information. If there is an author a part of the tls/ats is builded with this author information. There is no requirement from where the title nor author is comming. But in this issue and maybe in the related: no tls/ats is build at all! So its looks for me that this method is not called or called with an empty title and author.

@andre-hohmann
Copy link
Collaborator

@henning-gerhardt:
I think the TSL is generated, but without author-information:

But, TSL/ATS is created out of Title only (after pressing "Zahnrad"

The following issues must be examined seperately, escpecially, because existing functionality have been los.

@stefanCCS
Copy link
Collaborator Author

@stefanCCS can this be closed?

@Kathrin-Huber : Following the discussions here, it does not look like, that this can be closed.
But, I do not know the details - so, please decide, how to go on ...

@andre-hohmann
Copy link
Collaborator

Maybe, this can be solved by the following use-keys, which were probably defined by @matthias-ronge. I have not applied yet.

  • use="authorLastName" Der Wert wird als Nachname des Autors verwendet, um den Autortitelschlüssel zu bilden.
  • use="title" Dieses Feld wird als Titel zur Bildung des Autor-Titel-Schlüssels verwendet.

See: Schlüssel mit besonderer Verwendung

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ruleset ruleset functions and configuration
Projects
None yet
Development

No branches or pull requests

6 participants