Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate automaticallly 'process title', 'tiff header' and 'TSL/ATS' … #4905

Merged
merged 1 commit into from
Apr 25, 2022

Conversation

IkramMaalej
Copy link
Collaborator

@IkramMaalej IkramMaalej commented Jan 7, 2022

…after importing a process

Part of #4322
Fixes #3600

@andre-hohmann
Copy link
Collaborator

I think, the problem is solved: The fields "Process title" and "Tiff header document name" are filled immediately after the metadata import and the process title does not need to be generated manually anymore.

I think the problem is not solved. The value of the field author is not regarded in the generation of the TSL/ATS. Probably the reason is the application of metadata groups instead of one author field.
However, i am not sure, what the goal should be. Should the code be adjusted that only the field title is regarded, or should the code be adjusted, that also the fields of metadata groups for persons, are regarded for the generation of TSL/ATS?

I think the metadata groups should be regarded. But when the fields of the metadata groups are not standardized, it is difficult to name the fields.

Maybe the author of the issue can describe the expected result.

@matthias-ronge
Copy link
Collaborator

There is the use attribute in the ruleset to define the fields necessary for ATS/TSL creation. The title should be a <key id="…" use="title">, the author’s last name should be a <key id="…" use="authorLastName"> (and I did expected this to be possible in a group like Person), and the result should be written to the <key id="…" use="processTitle">. This is part of the ruleset definition (XSD file), but at the moment, the ruleset is not yet taken fully into acount, but some fields are hard-coded.

@IkramMaalej
Copy link
Collaborator Author

IkramMaalej commented Mar 20, 2022

I have removed this one #4461 because it is not yet fixed.
For now only this ruleset configuration <key id="…" use="processTitle"> has been considered in the code base to generate the process Title and ATS/TSL.
In addition to that, I found out that if the Role="Author" is assigned to a metadata group person, then this latter will be also considered for the generation of ATS/TSL.

@Kathrin-Huber Kathrin-Huber merged commit 3cf487f into kitodo:master Apr 25, 2022
@IkramMaalej IkramMaalej deleted the TSL-ATS branch November 1, 2022 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TSL/ATS is formed too late
4 participants