Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the list of pages in pagination dialog after applying the pagi… #4222

Merged
merged 2 commits into from
Mar 10, 2021
Merged

Update the list of pages in pagination dialog after applying the pagi… #4222

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a4bd117
Update the list of pages in pagination dialog after applying the pagi…
IkramMaalej Mar 1, 2021
1330566
Deselect the last paginated pages after applying the pagination
IkramMaalej Mar 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Kitodo/src/main/java/org/kitodo/production/forms/dataeditor/PaginationPanel.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,6 +374,8 @@ public void startPaginationClick() {
mediaUnits.get(i).setOrderlabel(paginator.next());
}
}
paginationSelectionSelectedItems = new ArrayList<>();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is already done in preparePaginationSelectionItems isn't it?

Copy link
Collaborator Author

@IkramMaalej IkramMaalej Mar 4, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but preparePaginationSelectionItems is not always called directly before a pagination because the user can make more than one pagination after each other before closing the popup. And if this PR #4214 will be merged, preparePaginationSelectionItems will be called only one time by opening the metadata editor.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I was confued between paginationSelectionSelectedItems and paginationSelectionItems 🤦

preparePaginationSelectionItems();
dataEditor.refreshStructurePanel();
}

Expand Down