-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
raise indexlimit to given limit from elasticsearch #4277
Conversation
I'm unsure, if your change is really fixing this problem or only moving it to an other issue. Between: If this changed method is called with a value for parameter |
But we already had this problem before, and this PR doesn't change anything on it. (a different PR may fix this Problem) |
Ok. I thought this PR should fix this issue for all time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will all documents be included in the resulting excel file if the system contains more than 10.000 documents? I obviously do not have enough processes to test this, but the linked issue description does say that all processes should be included in the excel file, not that the limit should just be increased from 1.000 to 10.000.
I don't know exactly, but somewhere there is a limit to the maximum number of rows in an Excel spreadsheet, right? Certainly not at 10,000 yet, but... |
That's right, only 10'000 documents will be included. but it is just not possible to get more than this (even with a loop, or paging ect...) Honestly, I hope that #4208 will fix this. This PR will at least add significant more documents to the excel sheet than 1000. |
I understand that the proposed change mitigates the problem a little, but it does not solve the linked issue. Therefore I would suggest to remove the link to the issue - so that it isn't closed when this PR gets merged - if no other changes are made to the pull request. With the limitations ElasticSearch 5 brings we should perhaps add a warning dialog that pops up if the system contains more than 10.000 processes and that informs the user that the resulting Excel file will not be complete because of technical restrictions. |
Maybe, i should create a new issue. The main problem ist, that it is not possible to retrieve more then 10.000 processes in Kitodo.Production. In some cases more hits have to be retrieved, for example:
It seems that the creation of the Excel file with more then 10.000 processes would be possible, if the more processes could be retrieved. |
I have created a issue: #4331. I strongly agree with @solth:
|
Elasticsearch is configured not to return more than 10'000 results (or to search behind that number).
It is not advised to change this value, but we can nevertheless get amounts up to this limit.