Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload files #4625

Merged
merged 16 commits into from
Sep 29, 2021
Merged

Upload files #4625

merged 16 commits into from
Sep 29, 2021

Conversation

solth
Copy link
Member

@solth solth commented Sep 2, 2021

This pull request adds a new feature to the metadata editor that allows users with appropriate permissions to upload new media files directly inside the editor to existing structure elements. The media is uploaded and all required png copies are automatically created according to the corresponding project folder configuration.

Uploaded files are not saved until the user explicitly saves the process in the editor, otherwise they are discarded to avoid unwanted changes in case the user changes his mind after the file upload.

Bildschirmfoto 2021-09-02 um 09 15 37

This restores the same functionality from Kitodo.Production 2 mentioned in #4163 and is part of the implementation for #4318

Known issue: in some rare cases, individual thumbnails for new images are not displayed immediately but require the user to Save the process and reopen it in the metadata editor.

@Kathrin-Huber
Copy link
Contributor

file_upload_error

StackTrace:
java.lang.NullPointerException at org.kitodo.production.forms.dataeditor.UploadFileDialog.setUpFolders(UploadFileDialog.java:231) at org.kitodo.production.forms.dataeditor.UploadFileDialog.prepare(UploadFileDialog.java:315)

@Kathrin-Huber Kathrin-Huber merged commit 7030e0f into kitodo:master Sep 29, 2021
@solth solth deleted the upload-files branch September 29, 2021 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants