-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upload files #4625
Merged
Merged
Upload files #4625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hout saving the changes.
…sion' and 'LogicalDivision'
IkramMaalej
force-pushed
the
upload-files
branch
from
September 21, 2021 08:01
28a18b6
to
2bb34a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a new feature to the metadata editor that allows users with appropriate permissions to upload new media files directly inside the editor to existing structure elements. The media is uploaded and all required png copies are automatically created according to the corresponding project folder configuration.
Uploaded files are not saved until the user explicitly saves the process in the editor, otherwise they are discarded to avoid unwanted changes in case the user changes his mind after the file upload.
This restores the same functionality from Kitodo.Production 2 mentioned in #4163 and is part of the implementation for #4318
Known issue: in some rare cases, individual thumbnails for new images are not displayed immediately but require the user to Save the process and reopen it in the metadata editor.