Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3316 switch to ajax request #4707

Merged

Conversation

markusweigelt
Copy link
Collaborator

Fixes #3316

Copy link
Collaborator

@matthias-ronge matthias-ronge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don’t understand what is happening here, but with regard to program style, etc., that is correct

@solth
Copy link
Member

solth commented Sep 29, 2021

@matthias-ronge Primefaces tags use Ajax per default (instead of vanilla JSF tags). Without using Ajax, the commadLink reloads the page (because the corresonding action returns "null" or is "void") which results in the "growl" message and the message area above the main content being updated with the message text. By using Ajax instead, the page reload is prevented and the message is only displayed in the specifically updated message area above the main content.

This solution is the same to what I did in #4615

@matthias-ronge
Copy link
Collaborator

Yes, I am not deep into this, but I agree.

@markusweigelt
Copy link
Collaborator Author

markusweigelt commented Sep 29, 2021

@solth I saw the issue and adapted it. ;) In my opinion, my fix is a workaround rather than a solution. Because in some cases an ajax variant will not be possible.

In the future, we should choose between output in flag/sticky-notification or top header message levels.

In order not to display flag/sticky-notifications in a disruptive way, we should update prime face cause lifetime of flag is not changeable. "life" attribute of growl does not work.

@Kathrin-Huber Kathrin-Huber merged commit 6d392bc into kitodo:master Sep 30, 2021
@markusweigelt markusweigelt deleted the reports_successful_export_only_once branch November 7, 2022 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reports successful export only once
4 participants