Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix correction workflow #4713

Merged
merged 5 commits into from
Oct 11, 2021

Conversation

solth
Copy link
Member

@solth solth commented Sep 30, 2021

Fixes #4686
Fixes #4555
Fixes #4653

Note: existing/active correction workflows should be closed before applying this update!

@solth solth force-pushed the correction-workflow branch from 53a24cd to 4ae375c Compare October 5, 2021 12:49
@solth solth force-pushed the correction-workflow branch from 4ae375c to 6e48ee1 Compare October 5, 2021 17:22
@IkramMaalej
Copy link
Collaborator

Without this migration, all processes that already have an open or closed correction workflow cannot have another error-free correction workflow. This means that this fix will only work with old processes that have never had a correction workflow or with processes that are being created.
UPDATE comment SET isCorrected = 1 WHERE type = 'ERROR'; UPDATE task SET correction = 0 WHERE process_id IS NOT NULL;

@IkramMaalej
Copy link
Collaborator

IkramMaalej commented Oct 11, 2021

Resolves #4555, #4653

@solth
Copy link
Member Author

solth commented Oct 11, 2021

Resolves #4555, #4653

#4653 cannot be verified by us. @andre-hohmann could you re-test your issue after this pull request has been merged into the master branch?

@Kathrin-Huber Kathrin-Huber merged commit 746e88a into kitodo:master Oct 11, 2021
@solth solth deleted the correction-workflow branch October 11, 2021 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants