Improve newspaper creation

[IkramMaalej]

Part of #4322
Fixes #3305
Fixes #3593
Fixes #3864
Fixes #3974
Fixes #4761
Fixes #4759
Fixes #4900

[solth]

Fixes #3305

✅

Fixes #3593

✅

Fixes #3864

✅

Fixes #3974

( ✅ ) Probably fixed

If I am not mistaken, the "Add metadata" buttons of the individual issues are still not fixed and leave the current view when scrolling through the metadata, don't they?

add-metadata-button.mov

[IkramMaalej]

@andre-hohmann : Can you please test this issue #4900 again to see if it has been fixed in meantime

[solth]

Fixes #4761

✅

Fixes #4759

✅

@andre-hohmann I added these changes to the current preview system. Could you check whether they fix #3974 in your opinion or not?

[andre-hohmann]

@IkramMaalej : #4900 has not been fixed. It is still possible to create newspaper processes with existing process titles:

[andre-hohmann]

@solth : #3974 is not fixed. It is necessary to scroll down to the new metadata element and then back up to the button "Metadatum hinzufügen" to create the next metadata element.
The button "Metadatum hinzufügen" should be shown always. For example next to the button "Schließen" or next to "Mo. 2010-01-04 (Block 1)" . See the gif below.
As the metadata element is created for all issues, there is no need for to buttons "Metadatum hinzufügen".

Is is not possible to show the metadata in a list as in the regular creation of processes? The button "Als letzte Ausgabe festlegen" could be added to each metadata field. It would then not be necessary to add all needed metadata elements manually and to chose the fields and values, ...
It would also be helpful, if the window was bigger.

Sorry, if i am only complaining, ... It is however great, that the standard-values of the ruleset are implemented.

[solth]

As the metadata element is created for all issues, there is no need for to buttons "Metadatum hinzufügen".

I am not sure, but I thought it's possible to add metadata to individual issues, hence the need for multiple buttons.
See @oliver-stoehr's comment from the linked issue:

The button was placed inside the scrollable area by design, because there can be multiple "add metadata" buttons.
When multiple issues occur on the same date, every issue has its own button to add metadata to this specific issue.
(The buttons are placed at the end bottom of the corresponding issue's area.)

[oliver-stoehr]

That's right. The metadata is added to all issues between the two specified dates and issues (e.g. "2010-01-04, 2-Spätausgabe" and "2010-03-04, 2-Spätausgabe"). If this specified beginning is for example the second issue on this date, the metadata will not be added to the first issue "Frühausgabe" (being outside the specified range).

[andre-hohmann]

@solth , @oliver-stoehr : I do not really understand the current state. When i use the button "Metadatum hinzufügen" as shown in the gif above, the element is added to both issues.
In my opinion, this is very good, because otherwise each metadata element has to be twice (if two issues will be created). That would be very cumbersome.

My question is now: Is my observation incorrect? Is it not possible to move the button "Metadatum hinzufügen" to another position?

[andre-hohmann]

@solth : Here two general hints:

1. The Button "Ausgabe hinzufügen" is not striking enough. I click often "Block löschen" and "Block kopieren", because they are more striking due to the color. I use "Ausgabe hinzufügen" more often then "Block kopieren", ...
2. The field "Name" in the Issue-Blocks is mandatory and a text has to be inserted. When only one issue per day exists, we do not add a title. Therefore the field "Name" should not be mandatory - it must be possible to create newspaper processes without title.

[matthias-ronge]

Maybe the dialog needs a more concise design:

(the blue arrow should be a pencil)

[andre-hohmann]

@IkramMaalej: Thanks a lot for the improvements!

Summary

• Make calendar editor change year on 'enter' press #3305 -> is fixed
• Selection list missing by adding metadata for newspaper issues  #3593 -> is fixed
• Calendar editor missing confirmation when deleting blocks #3864 -> is fixed
• Creation of processes for newspaper issues: Depiction of button "Add metadata"  #3974 -> is fixed
• Creating newspaper processes - wrong color-labeling of issues #4761 -> is fixed
• Creating newspaper processes - text fields are covered when browser windows is zoomed #4759 -> is fixed
• Duplicates are created during creation of newspaper-processes - 2 #4900 -> is fixed

Review

1. Add metadata to all issues: The German label needs a correction: "hinzufügen" -> "hinzufügen".
2. Add metadata to all issues: The values of text-fields are added to all issues, when it is entered in the first issue. The values of selection lists or multiselect-fields are not added to all issues, when it is entered in the first issue.
   The goal should be that all kinds fields (text, selection-list, multi-select, ...) and its values should be added to all issues, when the button "Add metadata to all issues" is applied.
3. Duplicate-check: If two issues are created with the same label, the message is shown: Duplicate issue designations were found. This may produce duplicate process titles!: (Block 1). If two issues are created without label, no message is shown and the duplicate processes are not created. The last option should not occur, but the behavior of duplicate check should be the same in all use cases.
   The goal should be that the error message is always shown when the label of issues are the same - even if they are empty.