Save mapping file order for import configurations #5232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Sounds good but I have no such configuration in use so maybe @BartChris can verifiy this too as @BartChris has such a configuration scenario.
|
I applied your changes and i can confirm that they are working. |
|
@solth : I did already a review (which was good) and suggested to review this changes by BartChris. Why should I now review this pull request again as no changes was made since my last review? |
Because you didn't approve the pull request in your first review and @BartChris indeed confirmed that the changes work as intended. |
henning-gerhardt
approved these changes
Jul 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5229
Note @BartChris : since the order of mapping files in import configurations wasn't saved explicitly to the database yet, I had to initialize the new
sortingcolumn statically with0. This means that for import configurations with multiple mapping files that you created before this pull request, you need to edit the configuration again and re-assign the mapping files in the correct order. Then they will be saved correctly to the database.