Add switch to hide/show inactive templates #5353
Conversation
There was a problem hiding this comment.
The implemented toggle UI component looks a bit out of character:
In other views there is a menu at the bottom of the list, which allows to show or hide certain elements, e.g. the task list:
Maybe such a menu would be more consistent with the existing design language of Kitodo?
| */ | ||
| public List<TemplateDTO> getTemplates() { | ||
| return templates; | ||
| return templates.stream().filter(TemplateDTO::isActive).collect(Collectors.toList()); |
There was a problem hiding this comment.
I think it would be better not to add logic to a DTO bean. If inactive templates are not needed when querying a project for its templates, they should probably not be indexed in the first place?
There was a problem hiding this comment.
I agree with you in principle about avoiding business logic in DTOs, but I think we still need to add inactive templates to the index. Most list views are filled from the index and unless I miss something here we wouldn't be able to edit and re-activate inactive templates if they were not in the index and consequently would not appear in the list.
solth
force-pushed
the
inactive-templates
branch
2 times, most recently
from
65e52e1 to
6ef11be
Compare
solth
force-pushed
the
inactive-templates
branch
from
6ef11be to
16dc7f2
Compare
solth
force-pushed
the
inactive-templates
branch
from
16dc7f2 to
5f989d6
Compare
solth
force-pushed
the
inactive-templates
branch
from
5f989d6 to
951c10d
Compare
solth
force-pushed
the
inactive-templates
branch
from
951c10d to
a5dbf1e
Compare
Fixes #3311
Instead of removing the switch to create unreachable templates, as was proposed in the linked issue, this pull requests restores the - presumably - intended behaviour of filtering the list of templates available to create a new process for a project by the templates
activevalues. In addition, a switch in the template list on the project page can be used to toggle whether inactive templates are shown in that list or not.