Improve id column for larger ids #5465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please rebase against master to fix broken Github CI builds! |
andre-hohmann
approved these changes
Nov 29, 2022
There was a problem hiding this comment.
@oliver-stoehr : Thanks! From the user perspective it is OK.
| @@ -22,7 +22,7 @@ | |||
| styleClass="default-layout" | |||
| var="process"> | |||
| <p:column headerText="#{msgs.id}" | |||
| width="50" | |||
| width="70" | |||
There was a problem hiding this comment.
I don't know if its possible to move the width declarations here and on the other place to a style sheet property so the adjustment must be done only once and can maybe defined more granular.
henning-gerhardt
approved these changes
Jan 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The id column is now a little bit wider to display ids with up to seven digits on the desktop and the processes list.
In addition the column is now resizable on the processes list.
Resolves #3738.