Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata tree table #5550

Merged
merged 3 commits into from
Mar 1, 2023
Merged

Conversation

IkramMaalej
Copy link
Collaborator

Fixes #3450
Fixes #3370

@IkramMaalej IkramMaalej force-pushed the metadataTreeTable branch 3 times, most recently from 840b362 to 13e45e0 Compare February 28, 2023 12:57
@markusweigelt markusweigelt self-requested a review February 28, 2023 16:09
@solth solth force-pushed the metadataTreeTable branch from 13e45e0 to 8e8b91a Compare February 28, 2023 16:16
Copy link
Collaborator

@markusweigelt markusweigelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work and code looks good for me!

Issue 5550 is not completely fixed

If the dialog shows a tab in which there were no errors, but only errors in another tab, it should switch to one of the tabs in which errors occurred.

image

In my case i navigate to "Title record link" tab and press save. The errors occurs in tab "Process data" but tab did not switched.

Issue 3450 is not completely fixed cause asterisk is missing on process title label.

image

<p:outputLabel for="#{item.input eq 'dataTable' ? '' : item.input}"
value="#{item.label}: #{item.required ? ' *' :''}"
rendered="#{not item.undefined}"/>
<p:outputLabel value="#{item.label}: ⚠️"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the last character here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<p:outputLabel value="#{item.label}: ⚠️" style="background-color: gold;" title="#{msgs['dataEditor.undefinedKey']}" rendered="#{item.undefined}"/>

If an imported metadata is not defined in the ruleset, its label is marked with this character ⚠️

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks i thought it was an incorrect character.

@solth solth merged commit 414b1b4 into kitodo:master Mar 1, 2023
@IkramMaalej IkramMaalej deleted the metadataTreeTable branch March 1, 2023 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mandatory fields are not marked Error message unsightly
3 participants