-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metadata tree table #5550
Metadata tree table #5550
Conversation
840b362
to
13e45e0
Compare
13e45e0
to
8e8b91a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work and code looks good for me!
Issue 5550 is not completely fixed
If the dialog shows a tab in which there were no errors, but only errors in another tab, it should switch to one of the tabs in which errors occurred.
In my case i navigate to "Title record link" tab and press save. The errors occurs in tab "Process data" but tab did not switched.
Issue 3450 is not completely fixed cause asterisk is missing on process title label.
<p:outputLabel for="#{item.input eq 'dataTable' ? '' : item.input}" | ||
value="#{item.label}: #{item.required ? ' *' :''}" | ||
rendered="#{not item.undefined}"/> | ||
<p:outputLabel value="#{item.label}: ⚠️" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the last character here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<p:outputLabel value="#{item.label}: ⚠️" style="background-color: gold;" title="#{msgs['dataEditor.undefinedKey']}" rendered="#{item.undefined}"/>
If an imported metadata is not defined in the ruleset, its label is marked with this character ⚠️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks i thought it was an incorrect character.
8e8b91a
to
25983cc
Compare
Fixes #3450
Fixes #3370