Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate task and tasks status in combination #5878

Merged

Conversation

solth
Copy link
Member

@solth solth commented Jan 12, 2024

Fixes #3341 by validating task and taskStatus in combination, using OmniFaces validateAllOrNone

Bildschirmfoto 2024-01-12 um 14 20 55

@solth solth requested a review from markusweigelt January 15, 2024 11:06
Copy link
Collaborator

@markusweigelt markusweigelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me!

Perhaps you could rearrange the sequence of task errors, but it's possible that the behavior is stemming from the Omniface validator.
Therefore, I approve in any case!
image

@solth
Copy link
Member Author

solth commented Jan 17, 2024

Perhaps you could rearrange the sequence of task errors, but it's possible that the behavior is stemming from the Omniface validator.

I was able to change to order of the validation messages by simple adjusting the corresponding tags!
Bildschirmfoto 2024-01-17 um 11 27 43

@markusweigelt
Copy link
Collaborator

@solth Ok I was not aware that it could be misunderstood. I meant the sequence of 'Aufgabenstatus, Aufgabe -> Aufgabe, Aufgabenstatus'. Sorry for the insufficient description.

@solth
Copy link
Member Author

solth commented Jan 17, 2024

@solth Ok I was not aware that it could be misunderstood. I meant the sequence of 'Aufgabenstatus, Aufgabe -> Aufgabe, Aufgabenstatus'. Sorry for the insufficient description.

Do not underestimate my ability to misunderstand people 😄

But that change was easy, too. Is this how it should look?
Bildschirmfoto 2024-01-17 um 11 53 11

@markusweigelt
Copy link
Collaborator

😄 Great thx!

@solth solth merged commit 2d95369 into kitodo:master Jan 17, 2024
2 checks passed
@solth solth deleted the extended-search-combined-validation branch January 17, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Advanced search’s task status filter not working
2 participants