-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update to vue3 and storybook 8 #481
Conversation
Thanks for getting this started! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! We need both of these upgrades, so I think it's fine not to do it incrementally.
Since this is dropping Vue 2 support, the commit message when squash-merging this should note the breaking change so that a new major version will be created https://www.conventionalcommits.org/en/v1.0.0/#commit-message-with-both--and-breaking-change-footer
1bb0cd3
to
28508b6
Compare
BREAKING CHANGE: Vue3 is now required
7c5d88f
to
af16665
Compare
@kiva/frontend-reviewers this is ready to be merged. I updated most of the stories and gave storybook a quick pass and all stories appear to be working |
@eddieferrer thanks for the work here! Looks like Chromatic encountered an error
|
Can we move to Storybook with vite like in CPS? |
Yeah looks like after I merged the package-lock and package from main, something went awry. Looking into it. |
I fixed the issues here, I mainly went with webpack because it was easier and required less changes to |
Looks like a new error in test run:
|
@kiva/frontend-reviewers ok this is complete and ready to merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for getting these updates in place. Being that this only touches 1 actual component, I think it can be safe to merge whenever. Will look for additional thoughts from others.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, pending current build issues in GitHub.
11473c9
to
a3109d0
Compare
Initial PR to update to Vue3 and Storybook 8
vue
to be vue 3.This PR is working, but you can see the changes I had to make to these 2 stories. This change will have to be made to the rest of the stories.
There may also need to be additional changes made to preview.js to import VueRouter, and other built in components
I'm open to suggestions for an more incremental way to do this.