Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update to vue3 and storybook 8 #481

Merged
merged 13 commits into from
Nov 27, 2024
Merged

feat: update to vue3 and storybook 8 #481

merged 13 commits into from
Nov 27, 2024

Conversation

eddieferrer
Copy link
Collaborator

@eddieferrer eddieferrer commented Nov 22, 2024

Initial PR to update to Vue3 and Storybook 8

  • First I tried to switch vue-demi to vue 3 using an alias for vue 3 or an alias for vue2 as detailed here: https://github.com/vueuse/vue-demi?tab=readme-ov-file#isomorphic-testings But this did not work because storybook has a deep dependency for vue to be vue 3.
  • I couldn't come up with an incremental way to get to storybook 8/vue 3, so I think we just have to update both at the same time.

This PR is working, but you can see the changes I had to make to these 2 stories. This change will have to be made to the rest of the stories.

There may also need to be additional changes made to preview.js to import VueRouter, and other built in components

I'm open to suggestions for an more incremental way to do this.

@mcstover
Copy link
Collaborator

Thanks for getting this started!

Copy link
Collaborator

@emuvente emuvente left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! We need both of these upgrades, so I think it's fine not to do it incrementally.

Since this is dropping Vue 2 support, the commit message when squash-merging this should note the breaking change so that a new major version will be created https://www.conventionalcommits.org/en/v1.0.0/#commit-message-with-both--and-breaking-change-footer

@eddieferrer
Copy link
Collaborator Author

@kiva/frontend-reviewers this is ready to be merged. I updated most of the stories and gave storybook a quick pass and all stories appear to be working

@dyersituations
Copy link
Collaborator

@eddieferrer thanks for the work here! Looks like Chromatic encountered an error

Storybook failed to load the following preset: @storybook/vue3-webpack5/preset.

@mcstover
Copy link
Collaborator

@eddieferrer thanks for the work here! Looks like Chromatic encountered an error

Storybook failed to load the following preset: @storybook/vue3-webpack5/preset.

Can we move to Storybook with vite like in CPS?

@eddieferrer
Copy link
Collaborator Author

Yeah looks like after I merged the package-lock and package from main, something went awry. Looking into it.

@eddieferrer
Copy link
Collaborator Author

@eddieferrer thanks for the work here! Looks like Chromatic encountered an error

Storybook failed to load the following preset: @storybook/vue3-webpack5/preset.

Can we move to Storybook with vite like in CPS?

I fixed the issues here, I mainly went with webpack because it was easier and required less changes to main.js

@dyersituations
Copy link
Collaborator

Looks like a new error in test run:

Error: Cannot find module 'tsconfig'

@eddieferrer
Copy link
Collaborator Author

@kiva/frontend-reviewers ok this is complete and ready to merge

Copy link
Collaborator

@mcstover mcstover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for getting these updates in place. Being that this only touches 1 actual component, I think it can be safe to merge whenever. Will look for additional thoughts from others.

Copy link
Collaborator

@dyersituations dyersituations left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, pending current build issues in GitHub.

@eddieferrer eddieferrer merged commit 82ee582 into main Nov 27, 2024
3 of 5 checks passed
@eddieferrer eddieferrer deleted the update_to_vue_3 branch November 27, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants