Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: composable for tiered badge data #5620

Merged
merged 2 commits into from
Oct 28, 2024
Merged

feat: composable for tiered badge data #5620

merged 2 commits into from
Oct 28, 2024

Conversation

dyersituations
Copy link
Collaborator

https://kiva.atlassian.net/browse/MP-966

  • Partial implementation to allow for other engineers to utilize this work
  • Created composable for combining badge tiered achievements and contentful data
  • Work to come: comments, unit tests, using on MyKiva correctly, etc.
  • This doesn't break the page more than it already is currently 😄

roger-in-kiva
roger-in-kiva approved these changes Oct 28, 2024
View reviewed changes
Copy link
Collaborator

@roger-in-kiva roger-in-kiva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@dyersituations dyersituations merged commit 48be875 into main Oct 28, 2024
5 checks passed
@dyersituations dyersituations deleted the MP-966-fe-badge-journey-should-use-tiered-badge-icons branch October 28, 2024 20:03
@kiva-robot
Copy link
Collaborator

🎉 This PR is included in version 3.2.0-rc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@kiva-robot
Copy link
Collaborator

🎉 This PR is included in version 3.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roger-in-kiva roger-in-kiva roger-in-kiva approved these changes

@christian14b christian14b christian14b approved these changes

Assignees
No one assigned
Labels
released on @staging released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dyersituations @kiva-robot @christian14b @roger-in-kiva