-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: my kiva stats bug #5656
Merged
Merged
fix: my kiva stats bug #5656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dyersituations
approved these changes
Nov 7, 2024
kiva-robot
added a commit
that referenced
this pull request
Nov 19, 2024
## [3.4.0-rc.2](v3.4.0-rc.1...v3.4.0-rc.2) (2024-11-19) ### 🎉 New Features * add badge shine and rays animations ([d940405](d940405)) * add initial component for MyKiva thanks experience ([117f0ed](117f0ed)) * add tracking events to typage components ([261fb3d](261fb3d)) * change tab on swipe ([a81108e](a81108e)) * filter loans in carousel by status ([a31c765](a31c765)) * increase limit in my kiva query to ensure 9 loans in carousel ([d01f96f](d01f96f)) * initial badges module for MyKiva TY page ([07b0e61](07b0e61)) * journal updates analytics ([#5695](#5695)) ([b9362a2](b9362a2)) * lender profile link added to my kiva nav ([#5675](#5675)) ([e7abcc9](e7abcc9)) * my kiva analytic labels updated ([#5689](#5689)) ([647573c](647573c)) * my kiva first login for guest claim flow ([#5686](#5686)) ([0e3dff4](0e3dff4)) * my kiva header badge tile ([#5655](#5655)) ([874d0bb](874d0bb)) * opted in state of TY experience for MyKiva ([ff220b6](ff220b6)) * scroll MyKiva section into view after async data is loaded ([5c15b66](5c15b66)) * scroll to section when clicking continue as logged in user ([4fb5b2c](4fb5b2c)) * show guest account creation on continue on new TY badge page ([36b42d1](36b42d1)) * show lastname in my kiva profile ([#5670](#5670)) ([a90dba7](a90dba7)) * toggle what is next for all cards and fix number of loans in carousel to match tabs ([89e7ab0](89e7ab0)) * typage opt-in module component ([a88c9e5](a88c9e5)) * using useBadgeData composable to get share content ([d51d7c8](d51d7c8)) ### 🐛 Bugfixes * add font book to module description ([d86ec10](d86ec10)) * add optional chaining just in case ([5b26c67](5b26c67)) * add optional chaining just in case ([38ae0f9](38ae0f9)) * add TODO comment ([41d0aef](41d0aef)) * address warning from use of getBadgeShape in BadgeTile ([e50efcb](e50efcb)) * adjust badge width on MyKiva ([83d8d5a](83d8d5a)) * adjust spacing and sizing in badge tile for MyKiva ([834a96b](834a96b)) * adjust welcome text padding ([1d01064](1d01064)) * adjustments to badge modal ([37334a4](37334a4)) * avatar image sizes ([ffb8ad5](ffb8ad5)) * avatar sizes, borders and animation error ([1b2879d](1b2879d)) * badge tile loader fixed ([#5661](#5661)) ([cbce7cd](cbce7cd)) * badge tile width fixed ([#5671](#5671)) ([e149a2c](e149a2c)) * badgekey issue fixed in public lender profile ([#5663](#5663)) ([140dba4](140dba4)) * badges achieved value in events ([7a1bc17](7a1bc17)) * borrower image issues ([147fc7c](147fc7c)) * borrower status card fix ([#5677](#5677)) ([c725082](c725082)) * carousel was not using the filtered loans variable ([bec5f1a](bec5f1a)) * change smaller avatar size ([a7faf24](a7faf24)) * cleaned up expandable animation and mock data ([4e1fca1](4e1fca1)) * conflicts ([de6b3df](de6b3df)) * css media width ([6633953](6633953)) * gear icon width fixed ([#5691](#5691)) ([d648c40](d648c40)) * in progress badge container fixed ([#5658](#5658)) ([8ee5d3d](8ee5d3d)) * inner padding in buttons and single loan image size ([12d3d03](12d3d03)) * journal updates counter fixed ([#5696](#5696)) ([3ae2116](3ae2116)) * lent countries to value ([5f926b0](5f926b0)) * lint ([04de4f8](04de4f8)) * lint ([3e43e7d](3e43e7d)) * lint ([d236031](d236031)) * linting ([deeecdb](deeecdb)) * loan card updated in inprogress carousel ([#5669](#5669)) ([5ddb090](5ddb090)) * loans number fixed ([#5662](#5662)) ([f406542](f406542)) * match tracking events to epic ([1cd00e8](1cd00e8)) * move settings gear up ([542c06c](542c06c)) * my kiva bugs ([#5659](#5659)) ([9aceca7](9aceca7)) * my kiva stats bug ([#5656](#5656)) ([e0c9d65](e0c9d65)) * new config to enable stellate debug header and customFetch for logging ([d9e202e](d9e202e)) * notification design ([3da08b1](3da08b1)) * passing number of badges to optin module ([c7f0477](c7f0477)) * prevent scrolling to View all button ([84b0bb3](84b0bb3)) * remove onInteractCarousel to avoid duplication in tracking ([a762a60](a762a60)) * remove unwanted console logs ([acb0052](acb0052)) * resolve prop issue for a user with no previous lending ([b054a5d](b054a5d)) * show in-progress badges in impact journeys section ([0afaee8](0afaee8)) * show tier level in top badge tile ([f81e8f0](f81e8f0)) * solve conflicts ([70f68f1](70f68f1)) * start index added to badge in progress carousel ([#5668](#5668)) ([f9c4054](f9c4054)) * status card too wide and padding on large screens ([dcd7a59](dcd7a59)) * story badge size ([fa2dd07](fa2dd07)) * switch to user avatar ([7e14e16](7e14e16)) * text size for mobile ([9012158](9012158)) * title when no loans ([941e02d](941e02d)) * unused queries ([dc14e14](dc14e14)) * update mock old badge ([7609005](7609005)) * update notification avatar sizes for mobile and desktop ([e0e7914](e0e7914)) * updated analytics to match ticket requirements ([96ccc24](96ccc24)) * width in notification ([982b136](982b136)) ### 🪚 Refactors * prefetch badge queries ([54758ee](54758ee)) * use one query for badge data ([09edebf](09edebf)) * using kv avatar for notification ([c84fbc7](c84fbc7)) * using ready query ([d295d60](d295d60))
🎉 This PR is included in version 3.4.0-rc.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
kiva-robot
added a commit
that referenced
this pull request
Nov 20, 2024
## [3.4.0](v3.3.0...v3.4.0) (2024-11-20) ### 🎉 New Features * add badge shine and rays animations ([d940405](d940405)) * add buttons to modal and fix padding issues ([887014a](887014a)) * add initial component for MyKiva thanks experience ([117f0ed](117f0ed)) * add tracking events to typage components ([261fb3d](261fb3d)) * added loader for badge modal async components ([0a9d43b](0a9d43b)) * change tab on swipe ([a81108e](a81108e)) * filter loans in carousel by status ([a31c765](a31c765)) * footnote support for borrower status cards in MyKiva ([8a40ef9](8a40ef9)) * increase limit in my kiva query to ensure 9 loans in carousel ([d01f96f](d01f96f)) * initial badges module for MyKiva TY page ([07b0e61](07b0e61)) * journal updates analytics ([#5695](#5695)) ([b9362a2](b9362a2)) * lender profile link added to my kiva nav ([#5675](#5675)) ([e7abcc9](e7abcc9)) * my kiva analytic labels updated ([#5689](#5689)) ([647573c](647573c)) * my kiva first login for guest claim flow ([#5686](#5686)) ([0e3dff4](0e3dff4)) * my kiva header badge tile ([#5655](#5655)) ([874d0bb](874d0bb)) * opted in state of TY experience for MyKiva ([ff220b6](ff220b6)) * optional run & wait time recordings in vue worker pool ([202b393](202b393)) * scroll MyKiva section into view after async data is loaded ([5c15b66](5c15b66)) * scroll to section when clicking continue as logged in user ([4fb5b2c](4fb5b2c)) * setup apollo http link to switch to stellate uri for cachable operations ([7cf60d2](7cf60d2)) * show guest account creation on continue on new TY badge page ([36b42d1](36b42d1)) * show lastname in my kiva profile ([#5670](#5670)) ([a90dba7](a90dba7)) * toggle what is next for all cards and fix number of loans in carousel to match tabs ([89e7ab0](89e7ab0)) * typage opt-in module component ([a88c9e5](a88c9e5)) * use share info in badge earned modal ([9686771](9686771)) * using useBadgeData composable to get share content ([d51d7c8](d51d7c8)) ### 🐛 Bugfixes * add fallback for retries and remove console logs ([c0a5ac8](c0a5ac8)) * add font book to module description ([d86ec10](d86ec10)) * add optional chaining just in case ([5b26c67](5b26c67)) * add optional chaining just in case ([38ae0f9](38ae0f9)) * add TODO comment ([41d0aef](41d0aef)) * address warning from use of getBadgeShape in BadgeTile ([e50efcb](e50efcb)) * adjust badge width on MyKiva ([83d8d5a](83d8d5a)) * adjust retry query with optional chaining, make operations list configurable ([01c9db4](01c9db4)) * adjust spacing and sizing in badge tile for MyKiva ([834a96b](834a96b)) * adjust welcome text padding ([1d01064](1d01064)) * adjustments to badge modal ([37334a4](37334a4)) * another adjustment to hiding UI while waiting for data ([17c065b](17c065b)) * avatar image sizes ([ffb8ad5](ffb8ad5)) * avatar sizes, borders and animation error ([1b2879d](1b2879d)) * badge tile loader fixed ([#5661](#5661)) ([cbce7cd](cbce7cd)) * badge tile width fixed ([#5671](#5671)) ([e149a2c](e149a2c)) * badgekey issue fixed in public lender profile ([#5663](#5663)) ([140dba4](140dba4)) * badges achieved value in events ([7a1bc17](7a1bc17)) * borrower carousel in MyKiva should have consistent height ([831f899](831f899)) * borrower image issues ([147fc7c](147fc7c)) * borrower status card fix ([#5677](#5677)) ([c725082](c725082)) * carousel was not using the filtered loans variable ([bec5f1a](bec5f1a)) * change smaller avatar size ([a7faf24](a7faf24)) * cleaned up expandable animation and mock data ([4e1fca1](4e1fca1)) * conflicts ([de6b3df](de6b3df)) * conflicts ([f0d9d59](f0d9d59)) * copy and style for no loans ([079a751](079a751)) * create separate options object, temporarily bypass csp for stellate for experimentation ([da63ed8](da63ed8)) * css media width ([6633953](6633953)) * do not show back button on earned section ([59735a7](59735a7)) * donate link fixed on mykiva nav ([#5699](#5699)) ([1a54df2](1a54df2)) * gear icon width fixed ([#5691](#5691)) ([d648c40](d648c40)) * in progress badge container fixed ([#5658](#5658)) ([8ee5d3d](8ee5d3d)) * inner padding in buttons and single loan image size ([12d3d03](12d3d03)) * journal updates counter fixed ([#5696](#5696)) ([3ae2116](3ae2116)) * lent countries to value ([5f926b0](5f926b0)) * lint ([04de4f8](04de4f8)) * lint ([3e43e7d](3e43e7d)) * lint ([d236031](d236031)) * linting ([deeecdb](deeecdb)) * loan card updated in inprogress carousel ([#5669](#5669)) ([5ddb090](5ddb090)) * loans number fixed ([#5662](#5662)) ([f406542](f406542)) * match tracking events to epic ([1cd00e8](1cd00e8)) * move settings gear up ([542c06c](542c06c)) * my kiva bugs ([#5659](#5659)) ([9aceca7](9aceca7)) * my kiva stats bug ([#5656](#5656)) ([e0c9d65](e0c9d65)) * mykiva mobile loan card width fixed ([#5700](#5700)) ([f19529d](f19529d)) * new config to enable stellate debug header and customFetch for logging ([d9e202e](d9e202e)) * notification design ([3da08b1](3da08b1)) * padding and back action ([e614992](e614992)) * passing number of badges to optin module ([c7f0477](c7f0477)) * prevent scrolling to View all button ([84b0bb3](84b0bb3)) * remove click from non-tiered badges ([2c4bdae](2c4bdae)) * remove onInteractCarousel to avoid duplication in tracking ([a762a60](a762a60)) * remove small design on modal ([6d25095](6d25095)) * remove unwanted console logs ([acb0052](acb0052)) * resolve MyKiva settings menu location issue ([ab01531](ab01531)) * resolve prop issue for a user with no previous lending ([b054a5d](b054a5d)) * show in-progress badges in impact journeys section ([0afaee8](0afaee8)) * show tier level in top badge tile ([f81e8f0](f81e8f0)) * solve conflicts ([70f68f1](70f68f1)) * start index added to badge in progress carousel ([#5668](#5668)) ([f9c4054](f9c4054)) * status card too wide and padding on large screens ([dcd7a59](dcd7a59)) * story badge size ([fa2dd07](fa2dd07)) * switch to user avatar ([7e14e16](7e14e16)) * text size for mobile ([9012158](9012158)) * title when no loans ([941e02d](941e02d)) * unused queries ([dc14e14](dc14e14)) * update gifts url in the footer to new path ([13d71b6](13d71b6)) * update mock old badge ([7609005](7609005)) * update notification avatar sizes for mobile and desktop ([e0e7914](e0e7914)) * update string to array conversion ([4608ff4](4608ff4)) * updated analytics to match ticket requirements ([96ccc24](96ccc24)) * width in notification ([982b136](982b136)) ### 🪚 Refactors * prefetch badge queries ([54758ee](54758ee)) * use one query for badge data ([09edebf](09edebf)) * using kv avatar for notification ([c84fbc7](c84fbc7)) * using ready query ([d295d60](d295d60)) ### 🧹 Chores * add stellate testing values to local config ([aed39e1](aed39e1)) * **release:** 3.4.0-rc.1 [skip ci] ([60761e2](60761e2)) * **release:** 3.4.0-rc.2 [skip ci] ([16f3e13](16f3e13)), closes [#5695](#5695) [#5675](#5675) [#5689](#5689) [#5686](#5686) [#5655](#5655) [#5670](#5670) [#5661](#5661) [#5671](#5671) [#5663](#5663) [#5677](#5677) [#5691](#5691) [#5658](#5658) [#5696](#5696) [#5669](#5669) [#5662](#5662) [#5659](#5659) [#5656](#5656) [#5668](#5668) * **release:** 3.4.0-rc.3 [skip ci] ([47ba1b0](47ba1b0)), closes [#5699](#5699) [#5700](#5700) * update build/docs url to our new graph uris ([5393ea5](5393ea5))
🎉 This PR is included in version 3.4.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
badges count fixed
For lives touched we are using the following data for consistency with previous page
livesTouched.value = result.data?.my?.lendingStats?.lentTo?.borrowers?.totalCount ?? 0;
Looks like is counting for fully fundraised loans only.