Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: Numerous issues with links were reported by the Play Store. #3550

Merged
merged 1 commit into from
Nov 25, 2023

Conversation

MohitMaliFtechiz
Copy link
Collaborator

Fixes #3549

  • The Play Store highlighted the need to add "/" to the beginning of the android:pathPattern. As a result, we have now included "/" at the beginning of all android:pathPattern instances to ensure compatibility with the Play Store. Also we have added category BROWSABLE to the scheme of the content type that is reported by the play store.
Play store error Play store error Play store for category
Screenshot from 2023-11-23 14-28-03 Screenshot from 2023-11-23 12-29-59 Screenshot from 2023-11-23 12-27-32
  • Additionally, the android:autoVerify="true" attribute has been added to intent filters to verify domain ownership. This was identified as an issue by both the Play Store and the App Links Assistant tool in Android Studio.

Screenshot from 2023-11-23 14-47-18

Copy link

codecov bot commented Nov 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4929c5a) 49.00% compared to head (c5ee5e6) 49.29%.

❗ Current head c5ee5e6 differs from pull request most recent head 04868ec. Consider uploading reports for the commit 04868ec to get more accurate results

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #3550      +/-   ##
=============================================
+ Coverage      49.00%   49.29%   +0.28%     
  Complexity      1082     1082              
=============================================
  Files            285      285              
  Lines          10448    10448              
  Branches        1398     1398              
=============================================
+ Hits            5120     5150      +30     
+ Misses          4500     4479      -21     
+ Partials         828      819       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

* The Play Store highlighted the need to add "/" to the beginning of the `android:pathPattern`. As a result, we have now included "/" at the beginning of all `android:pathPattern` instances to ensure compatibility with the Play Store.
* Additionally, the `android:autoVerify="true"` attribute has been added to intent filters to verify domain ownership. This was identified as an issue by both the Play Store and the App Links Assistant tool in Android Studio.
@kelson42 kelson42 merged commit edee77d into develop Nov 25, 2023
8 checks passed
@kelson42 kelson42 deleted the Issue#3549 branch November 25, 2023 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lots of problem with links (reported by PlayStore)
3 participants