Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjusted the zone for triggering search suggestions. #3566

Merged
merged 7 commits into from
Dec 6, 2023
Merged

Conversation

MohitMaliFtechiz
Copy link
Collaborator

@MohitMaliFtechiz MohitMaliFtechiz commented Dec 1, 2023

Fixes #3547
Fixes #3528 See #3528 (comment)

  • We had restricted the toolbar click to the toolbar title. So, if the user clicked on the title, it would initiate the search. Now, we have removed the restriction of clicking only on the title. If the user taps anywhere on the toolbar except the menu items and hamburger, it will initiate the search.
Increasedzone.mp4

appiconhamburger

With custom placeholder

Screenshot_20231204-192239_Test Custom App

Hidetitleandshowplaceholder.mp4

For normal custom apps

Hideplaceholderandshowtitle.mp4

Copy link

codecov bot commented Dec 1, 2023

Codecov Report

Attention: 35 lines in your changes are missing coverage. Please review.

Comparison is base (2a3d479) 49.02% compared to head (e391b40) 48.97%.

Files Patch % Lines
...x/kiwixmobile/core/extensions/ContextExtensions.kt 0.00% 21 Missing ⚠️
.../kiwix/kiwixmobile/core/main/CoreReaderFragment.kt 18.18% 7 Missing and 2 partials ⚠️
...n/java/org/kiwix/kiwixmobile/core/main/MainMenu.kt 50.00% 2 Missing and 3 partials ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #3566      +/-   ##
=============================================
- Coverage      49.02%   48.97%   -0.06%     
- Complexity      1084     1089       +5     
=============================================
  Files            285      285              
  Lines          10459    10495      +36     
  Branches        1398     1404       +6     
=============================================
+ Hits            5128     5140      +12     
- Misses          4503     4525      +22     
- Partials         828      830       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kelson42
Copy link
Collaborator

kelson42 commented Dec 5, 2023

@MohitMaliFtechiz Thank you, this proposal looks interesting but:

  • can you please rebase?
    *margins should be nice and the sam eleft and right of the inoutbox.

MohitMaliFtechiz and others added 7 commits December 6, 2023 15:59
* We had restricted the toolbar click to the toolbar title. So, if the user clicked on the title, it would initiate the search. Now, we have removed the restriction of clicking only on the title. If the user taps anywhere on the toolbar except the menu items and hamburger, it will initiate the search.
…vior, where setting the icon directly to the hamburger resulted in it taking the full width and height of the toolbar, we resized the app icon and applied it to the hamburger icon.
…s after closing the tabs screen in custom apps when the custom app is configured not to show the title.
* Introduced a search placeholder for custom apps; if any custom app is configured not to show the title in the toolbar, it will display the search placeholder with a border. To implement this change, a layout has been added inside the toolbar.
* To enhance understanding of this change, proper comments have been added to the methods.
@MohitMaliFtechiz
Copy link
Collaborator Author

can you please rebase?
*margins should be nice and the sam eleft and right of the inoutbox.

@kelson42 Rebased, and fixed the margin of the placeholder.

Samsung Pixel 7a
samsung_phone pixel7a

Copy link
Collaborator

@gouri-panda gouri-panda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kelson42 kelson42 merged commit 64582cf into develop Dec 6, 2023
9 of 10 checks passed
@kelson42 kelson42 deleted the Issue#3547 branch December 6, 2023 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants