-
-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjusted the zone for triggering search suggestions. #3566
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #3566 +/- ##
=============================================
- Coverage 49.02% 48.97% -0.06%
- Complexity 1084 1089 +5
=============================================
Files 285 285
Lines 10459 10495 +36
Branches 1398 1404 +6
=============================================
+ Hits 5128 5140 +12
- Misses 4503 4525 +22
- Partials 828 830 +2 ☔ View full report in Codecov by Sentry. |
@MohitMaliFtechiz Thank you, this proposal looks interesting but:
|
* We had restricted the toolbar click to the toolbar title. So, if the user clicked on the title, it would initiate the search. Now, we have removed the restriction of clicking only on the title. If the user taps anywhere on the toolbar except the menu items and hamburger, it will initiate the search.
…vior, where setting the icon directly to the hamburger resulted in it taking the full width and height of the toolbar, we resized the app icon and applied it to the hamburger icon.
…s after closing the tabs screen in custom apps when the custom app is configured not to show the title.
* Introduced a search placeholder for custom apps; if any custom app is configured not to show the title in the toolbar, it will display the search placeholder with a border. To implement this change, a layout has been added inside the toolbar. * To enhance understanding of this change, proper comments have been added to the methods.
e9b245f
to
e391b40
Compare
@kelson42 Rebased, and fixed the margin of the placeholder.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kelson42 @MohitMaliFtechiz LGTM 🎉
Fixes #3547
Fixes #3528 See #3528 (comment)
Increasedzone.mp4
With custom placeholder
Hidetitleandshowplaceholder.mp4
For normal custom apps
Hideplaceholderandshowtitle.mp4