Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change "Support Kiwix" icon in Sidebar #3589

Closed
wants to merge 1 commit into from
Closed

Change "Support Kiwix" icon in Sidebar #3589

wants to merge 1 commit into from

Conversation

Jawad-Hameed
Copy link

@Jawad-Hameed Jawad-Hameed commented Dec 10, 2023

Fixes #3585

change "Support Kiwix" icon in Sidebar

Screenshots
Screenshot_20231210-091139

Copy link

codecov bot commented Dec 10, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e391b40) 48.97% compared to head (da41a75) 48.94%.
Report is 1 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #3589      +/-   ##
=============================================
- Coverage      48.97%   48.94%   -0.03%     
+ Complexity      1089     1085       -4     
=============================================
  Files            285      285              
  Lines          10495    10495              
  Branches        1404     1404              
=============================================
- Hits            5140     5137       -3     
+ Misses          4525     4524       -1     
- Partials         830      834       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gouri-panda
Copy link
Collaborator

@kelson42 what do you think about the logo? What should we include? This PR is what you intend for the logo. We already have 2 different types of PR.

@Jawad-Hameed
Copy link
Author

@kelson42 what do you think about the logo? What should we include? This PR is what you intend for the logo. We already have 2 different types of PR.

I have solved this issue #3585 and changed the Support Kiwix icon in the sidebar menu. This icon was recommended by @kelson42 (Author). I have created this icon and replaced it in the project. That looks Good and naturally matches with text

@kelson42
Copy link
Collaborator

Sorry we already had PR #3588 to fix this.

@kelson42 kelson42 closed this Dec 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Sidebar "Support Kiwix" icon
3 participants