Updated detekt configuration to support compose: #4178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MohitMaliFtechiz
requested changes
Jan 22, 2025
There was a problem hiding this comment.
@jackq97 There is some compilation error when I am running the detekt.
./gradlew ktlintCheck detektDebug detektCustomExampleDebug app:lintDebug custom:lintCustomexampleDebug --daemon
* Increased the `functionThreshold` for `LongParameterList` from 6 to 8. * Enabled `ignoreDefaultParameters` for `LongParameterList`. * Updated `functionPattern` to allow uppercase letters at the beginning. * Add `ignoreAnnotatedFunctions` to `['Preview']` * Add `ignoreAnnotated` to `['Composable']` * Updated `constantPattern` to accept uppercase letters followed by alphanumeric characters. * Enabled `ignorePropertyDeclaration` for `MagicNumber`.
- Removed 'Preview' from `ignoreAnnotatedFunctions` in Complexity rule set. 'not supported in this version' - Updated `constantPattern` to `[A-Z][_A-Z0-9]*` for TopLevelPropertyNaming rule. - Added 'Preview' to `ignoreAnnotated` in UnusedPrivateMember rule set.
|
@MohitMaliFtechiz Pushed the updated file, please check it. all checks are passed in detektDebug. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked issue #4159
functionThresholdforLongParameterListfrom 6 to 8.ignoreDefaultParametersforLongParameterList.functionPatternto allow uppercase letters at the beginning.ignoreAnnotatedFunctionsto['Preview']ignoreAnnotatedto['Composable']constantPatternto accept uppercase letters followed by alphanumeric characters.ignorePropertyDeclarationforMagicNumber.followed resource https://detekt.dev/docs/introduction/compose/
to edit the properties to support composable functions in detekt config.