Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: Navigation drawer showing while reading a book in fullscreen mode. #4189

Merged
merged 1 commit into from
Jan 26, 2025

Conversation

MohitMaliFtechiz
Copy link
Collaborator

Fixes #4184

  • Disabled the right drawer when the user is reading a book in fullscreen mode to ensure uninterrupted reading.
  • Also disabled the drawer while a video is playing in fullscreen mode to avoid interruptions during video playback.
screen-20250124-164154.mp4

Copy link

codecov bot commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 28.57143% with 10 lines in your changes missing coverage. Please review.

Project coverage is 56.73%. Comparing base (99aae94) to head (22a3b4d).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
.../kiwix/kiwixmobile/core/main/CoreReaderFragment.kt 0.00% 8 Missing ⚠️
...bile/nav/destination/reader/KiwixReaderFragment.kt 0.00% 1 Missing ⚠️
...rg/kiwix/kiwixmobile/core/main/CoreMainActivity.kt 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #4189      +/-   ##
============================================
+ Coverage     56.68%   56.73%   +0.04%     
- Complexity     1524     1532       +8     
============================================
  Files           313      313              
  Lines         13477    13490      +13     
  Branches       1688     1693       +5     
============================================
+ Hits           7640     7653      +13     
- Misses         4671     4682      +11     
+ Partials       1166     1155      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…ode.

* Disabled the right drawer when the user is reading a book in fullscreen mode to ensure uninterrupted reading.
* Also disabled the drawer while a video is playing in fullscreen mode to avoid interruptions during video playback.
@kelson42 kelson42 merged commit 948b8cc into main Jan 26, 2025
29 of 31 checks passed
@kelson42 kelson42 deleted the Fixes#4184 branch January 26, 2025 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Navigation drawer is showing when we reading the book in full screen mode.
3 participants